Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix DropdownMenu throwing TextEditingController disposed error on select#139385

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gspencergoog:fix_dropdown_dispose
Dec 5, 2023
Merged

Fix DropdownMenu throwing TextEditingController disposed error on select#139385
auto-submit[bot] merged 4 commits into
flutter:masterfrom
gspencergoog:fix_dropdown_dispose

Conversation

@gspencergoog
Copy link
Copy Markdown
Contributor

@gspencergoog gspencergoog commented Dec 1, 2023 •
edited
Loading

Description

When a DropdownMenu exists within another menu and a MenuItem is selected, the TextEditingController of the DropdownMenu is used after it has been disposed.

This PR manages the local TextController instance better, making sure that the one used when building is the current one, and handling the case where the controller is set on the widget after initial creation.

Also, places where we were setting the text and selection separately were converted to use TextEditingValue and set the value atomically.

Related Issues

Tests

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 1, 2023
@gspencergoog gspencergoog mentioned this pull request Dec 1, 2023
Closed
8 tasks
gspencergoog
gspencergoog commented Dec 1, 2023
View reviewed changes
Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
Copy link
Copy Markdown
Contributor Author

@gspencergoog gspencergoog Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the problem here was that the text editing controller that was passed in was being captured by the closure, rather than being accessed new each time, so it would capture an instance that was no longer current. There's no need to pass it in, since it's a member of the state class.

gspencergoog
gspencergoog commented Dec 1, 2023
View reviewed changes
Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
Copy link
Copy Markdown
Contributor Author

@gspencergoog gspencergoog Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code wasn't handling the case where the widget got a new controller later on. It would just ignore any controller that was set later, and continue using the one it originally constructed.

navaronbracke
navaronbracke reviewed Dec 1, 2023
View reviewed changes
Comment thread packages/flutter/lib/src/material/dropdown_menu.dart Outdated
@gspencergoog gspencergoog changed the title Fix DropdownMenu throwing TextEditingController disposed error on select Fix DropdownMenu throwing TextEditingController disposed error on select Dec 1, 2023
QuncCccccc
QuncCccccc approved these changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit Bot merged commit 8ec4c59 into flutter:master Dec 5, 2023
@Hixie Hixie mentioned this pull request Dec 5, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
52b37f1 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
341e1eb 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
84d5fbd 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
1e91d05 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
0433e59 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
4911e26 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
14e0b1f 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
28d35b7 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
81990be 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
26f08a1 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
da9cc52 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
3c40779 
…error on select (flutter/flutter#139385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
3c2c7f4 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
0d27ed3 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
a02b8f0 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
6bc81b1 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
0402555 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
1d71eb9 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
0a2bac1 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
f984914 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
71654c0 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
69f2aad 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
b357cb1 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
99f5af1 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
d55c73b 
…error on select (flutter/flutter#139385)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
7ecf79b 
…error on select (flutter/flutter#139385)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
8ec4c59 Fix DropdownMenu throwing TextEditingController disposed …
9d520df 
…error on select (flutter/flutter#139385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navaronbracke navaronbracke navaronbracke left review comments

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested MenuAnchors throw 'A TextEditingController was used after being disposed' when MenuItem is selected

3 participants

@gspencergoog @navaronbracke @QuncCccccc