Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Send an event when proxied DDS creates a connection.#139530

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
chingjun:proxied-dds-event
Dec 5, 2023
Merged

Send an event when proxied DDS creates a connection.#139530
auto-submit[bot] merged 2 commits into
flutter:masterfrom
chingjun:proxied-dds-event

Conversation

@chingjun
Copy link
Copy Markdown
Contributor

@chingjun chingjun commented Dec 5, 2023

The event allows tools to listen and connect to the original DDS port.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chingjun
Send an event when proxied DDS creates a connection.
fed917e 
The event allows tools to listen and connect to the original DDS port.
christopherfujino
christopherfujino approved these changes Dec 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 5, 2023
@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit Bot merged commit 7a9adfd into flutter:master Dec 5, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
c5b219f 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
5ced175 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
17e0815 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
5b3513f 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
f514964 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
9757f87 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
c194a1d 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
d60c089 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
974035c 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
1a27f56 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
64de312 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
ff57689 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
656542b 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
b996d76 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
43d8037 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
3f95d02 
…/flutter#139530)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
0c25bf4 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
958209a 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
7cbeaa9 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
e86b269 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
81209fd 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
4b280a1 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
4db0fa2 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
08453d3 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
8ef063d 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
05c52e7 
…/flutter#139530)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
7a9adfd Send an event when proxied DDS creates a connection. (flutter…
99c6121 
…/flutter#139530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingjun @christopherfujino