Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use dart analyze package for num.clamp #139867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use dart analyze package for num.clamp #139867

merged 2 commits into from
Dec 11, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

Extacted from #130101, dropped the @_debugAssert stuff from that PR so it's easier to review.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Dec 9, 2023
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review December 10, 2023 00:16
goderbauer
goderbauer approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dev/bots/custom_rules/analyze.dart Outdated
///
/// If a compilation unit can not be resolved, this function ignores the
/// corresponding dart source file and logs an error using [foundError].
Future<void> analyzeDirectoryWithRules(String flutterRootDirectory, List<AnalyzeRule> rules) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit misleading as it cannot analyze an arbitrary directory. It can only analyze a directory that contains the Flutter framework in package/flutter/lib. Any reason this couldn't just apply the rules generically to the directory passed in (and analyze.dart would just pass in the lib directory of flutter framework)? Or be explicit in the naming (e.g. analyzeFrameworkWithRules) that it is not able to analyze any directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how best to generalize this, so renamed the function to analyzeFrameworkWithRules and updated the documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Maybe we can figure out how to generalize this once we have a use case for generalizing it :)

dev/bots/custom_rules/analyze.dart

import 'dart:io' show Directory;

import 'package:analyzer/dart/analysis/analysis_context.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the pubspec to make analyzer a direct dependency instead of an auto-generated transitive one?

dev/bots/custom_rules/no_double_clamp.dart Outdated
}

@override
void applyTo(ResolvedUnitResult unit) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code organisation nit: Maybe place applyTo above reportViolations as per https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#order-other-class-members-in-a-way-that-makes-sense.

christopherfujino
christopherfujino approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this writing this and also creating a new smaller PR to unblock me!

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit aa60912 into flutter:master Dec 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
aa60912 Use dart analyze package for num.clamp (flutter/flutter#139867
e38ab98 
)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 12, 2023
@engine-flutter-autoroll
Manual roll Flutter from c642f4e to 9719097 (25 revisions) (#5648)
80aa46a 
Manual roll requested by [email protected]

flutter/flutter@c642f4e...9719097

2023-12-11 [email protected] Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936)
2023-12-11 [email protected] Fix SelectionArea select-word edge cases (flutter/flutter#136920)
2023-12-11 [email protected] Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933)
2023-12-11 [email protected] Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931)
2023-12-11 [email protected] Use dart analyze package for `num.clamp` (flutter/flutter#139867)
2023-12-11 [email protected] Roll pub packages (flutter/flutter#139926)
2023-12-11 [email protected] Handle the case when _CupertinoBackGestureDetector is disposed during the drag.  (flutter/flutter#139585)
2023-12-11 [email protected] Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331)
2023-12-11 [email protected] Improve slider's value indicator display test (flutter/flutter#139198)
2023-12-11 [email protected] Add `enabled` property to `ExpansionTile` (flutter/flutter#139519)
2023-12-11 [email protected] Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911)
2023-12-11 [email protected] Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891)
2023-12-10 [email protected] Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885)
2023-12-09 [email protected] Roll pub packages (flutter/flutter#139864)
2023-12-09 [email protected] Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863)
2023-12-09 [email protected] Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853)
2023-12-09 [email protected] Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851)
2023-12-09 [email protected] Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847)
2023-12-09 [email protected] Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837)
2023-12-08 [email protected] Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831)
2023-12-08 [email protected] [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590)
2023-12-08 [email protected] Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829)
2023-12-08 [email protected] Add Overlay.wrap for convenience (flutter/flutter#139823)
2023-12-08 [email protected] Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826)
2023-12-08 [email protected] Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LongCatIsLooong LongCatIsLooong deleted the framework-analyze branch December 12, 2023 07:49
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Manual roll Flutter from c642f4e to 9719097 (25 revisions) (flutter#5648
700824c 
)

Manual roll requested by [email protected]

flutter/flutter@c642f4e...9719097

2023-12-11 [email protected] Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936)
2023-12-11 [email protected] Fix SelectionArea select-word edge cases (flutter/flutter#136920)
2023-12-11 [email protected] Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933)
2023-12-11 [email protected] Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931)
2023-12-11 [email protected] Use dart analyze package for `num.clamp` (flutter/flutter#139867)
2023-12-11 [email protected] Roll pub packages (flutter/flutter#139926)
2023-12-11 [email protected] Handle the case when _CupertinoBackGestureDetector is disposed during the drag.  (flutter/flutter#139585)
2023-12-11 [email protected] Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331)
2023-12-11 [email protected] Improve slider's value indicator display test (flutter/flutter#139198)
2023-12-11 [email protected] Add `enabled` property to `ExpansionTile` (flutter/flutter#139519)
2023-12-11 [email protected] Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911)
2023-12-11 [email protected] Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891)
2023-12-10 [email protected] Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885)
2023-12-09 [email protected] Roll pub packages (flutter/flutter#139864)
2023-12-09 [email protected] Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863)
2023-12-09 [email protected] Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853)
2023-12-09 [email protected] Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851)
2023-12-09 [email protected] Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847)
2023-12-09 [email protected] Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837)
2023-12-08 [email protected] Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831)
2023-12-08 [email protected] [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590)
2023-12-08 [email protected] Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829)
2023-12-08 [email protected] Add Overlay.wrap for convenience (flutter/flutter#139823)
2023-12-08 [email protected] Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826)
2023-12-08 [email protected] Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
aa60912 Use dart analyze package for num.clamp (flutter/flutter#139867
1fa03b8 
)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Manual roll Flutter from c642f4e to 9719097 (25 revisions) (flutter#5648
da87711 
)

Manual roll requested by [email protected]

flutter/flutter@c642f4e...9719097

2023-12-11 [email protected] Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936)
2023-12-11 [email protected] Fix SelectionArea select-word edge cases (flutter/flutter#136920)
2023-12-11 [email protected] Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933)
2023-12-11 [email protected] Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931)
2023-12-11 [email protected] Use dart analyze package for `num.clamp` (flutter/flutter#139867)
2023-12-11 [email protected] Roll pub packages (flutter/flutter#139926)
2023-12-11 [email protected] Handle the case when _CupertinoBackGestureDetector is disposed during the drag.  (flutter/flutter#139585)
2023-12-11 [email protected] Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331)
2023-12-11 [email protected] Improve slider's value indicator display test (flutter/flutter#139198)
2023-12-11 [email protected] Add `enabled` property to `ExpansionTile` (flutter/flutter#139519)
2023-12-11 [email protected] Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911)
2023-12-11 [email protected] Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891)
2023-12-10 [email protected] Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885)
2023-12-09 [email protected] Roll pub packages (flutter/flutter#139864)
2023-12-09 [email protected] Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863)
2023-12-09 [email protected] Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853)
2023-12-09 [email protected] Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851)
2023-12-09 [email protected] Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847)
2023-12-09 [email protected] Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837)
2023-12-08 [email protected] Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831)
2023-12-08 [email protected] [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590)
2023-12-08 [email protected] Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829)
2023-12-08 [email protected] Add Overlay.wrap for convenience (flutter/flutter#139823)
2023-12-08 [email protected] Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826)
2023-12-08 [email protected] Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongCatIsLooong @goderbauer @christopherfujino