Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reverts "Set template and migrate apps to iOS 12 minimum" #140822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2024
Merged

Reverts "Set template and migrate apps to iOS 12 minimum" #140822

merged 1 commit into from
Jan 2, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 2, 2024

Reverts #140478
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:

  1. Change templates to IPHONEOS_DEPLOYMENT_TARGET, MinimumOSVersion, and Podfile platform :ios to 12.0.
  2. Add migrator for Podfile part to migrate platform :ios, '11.0' -> platform :ios, '12.0'
  3. Compile with -miphoneos-version-min=12.0
  4. Run the migrator on all example apps and integration tests.

See also #62902 and #85174 and #101963

Fixes #136060

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot requested a review from jmagman as a code owner January 2, 2024 20:48
@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 2, 2024
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Jan 2, 2024
@auto-submit auto-submit bot merged commit bd634f3 into master Jan 2, 2024
@auto-submit auto-submit bot deleted the revert_acdbcadb9e56be2f6d0099eb74ed754f44d63cbb branch January 2, 2024 20:49
@vashworth vashworth mentioned this pull request Jan 2, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 3, 2024
@engine-flutter-autoroll
bd634f3 Reverts "Set template and migrate apps to iOS 12 minimum" (fl…
294b5db 
…utter/flutter#140822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
bd634f3 Reverts "Set template and migrate apps to iOS 12 minimum" (fl…
f9fd7c9 
…utter/flutter#140822)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
bd634f3 Reverts "Set template and migrate apps to iOS 12 minimum" (fl…
b9a4a42 
…utter/flutter#140822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees

@loic-sharma loic-sharma

Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Targeting iOS 11 (Flutter default minimum) built with Xcode 15 crashes EXC_BAD_ACCESS when using the Networking framework
2 participants
@fluttergithubbot @loic-sharma