Rename isAvailableForEnvironment to isForEnvironment #143176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f307f5 to
e8b801d
Compare
Piinks
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Curious about the name, why change it? Recommended seems a bit unclear to me. We must use the right comparator for the given environment, it being recommended makes it seem optional?
There was a problem hiding this comment.
Happy to go with another name. "isIntendedForEnvironment"? Maybe just "isForEnvironment"?
There was a problem hiding this comment.
I renamed it to isForEnvironment which seems to avoid the confusion of Available and Recommended, let me know what you think.
This is part 4 of a broken down version of the flutter#140101 refactor. This PR renames isAvailableForEnvironment to isRecommendedForEnvironment and replaces a regular expression with a simple function.
e8b801d to
001316c
Compare
Piinks
approved these changes
Mar 6, 2024
|
Revert reason: made tree red. |
|
A reason for requesting a revert of flutter/flutter/143176 could |
|
Reason for revert: made tree red. |
|
looking at the dashboard (but not the logs), it seems much more likely that fd4ab4f is the cause of the recent failures |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
This reverts commit 5bd34ef.
auto-submit bot
added a commit
that referenced
this pull request
Mar 8, 2024
…" (#144855) Reverts: #143176 Initiated by: QuncCccccc Reason for reverting: made tree red. Original PR Author: Hixie Reviewed By: {Piinks} This change reverts the following previous change: This is part 4 of a broken down version of the #140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
Hixie
added a commit
to Hixie/flutter
that referenced
this pull request
Mar 8, 2024
This is part 4 of a broken down version of the flutter#140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
This is part 4 of a broken down version of the #140101 refactor. This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like `mainly_refactors` or `chess_master_experiment` or whatever, but I'm pretty sure the old behaviour was not intended.) ---- This is a reland of #143176 which was speculatively reverted in #144855 but turned out not to be the cause of the tree redness.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 11, 2024
Manual roll Flutter from 7c89ec8 to 3bb2e59 (31 revisions) Manual roll requested by [email protected] flutter/flutter@7c89ec8...3bb2e59 2024-03-11 [email protected] Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923) 2024-03-11 [email protected] Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920) 2024-03-11 [email protected] Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907) 2024-03-10 [email protected] Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858) 2024-03-10 [email protected] Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894) 2024-03-10 [email protected] Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891) 2024-03-09 [email protected] Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889) 2024-03-09 [email protected] Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887) 2024-03-09 [email protected] Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884) 2024-03-09 [email protected] Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876) 2024-03-09 [email protected] Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875) 2024-03-09 [email protected] Fix multiple calls to Slider's onChanged. (flutter/flutter#143680) 2024-03-09 [email protected] Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870) 2024-03-09 [email protected] Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866) 2024-03-09 [email protected] Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865) 2024-03-09 [email protected] Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864) 2024-03-09 [email protected] Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863) 2024-03-09 [email protected] Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862) 2024-03-09 [email protected] Upgrade vm_service. (flutter/flutter#144845) 2024-03-09 [email protected] Replace dead links (flutter/flutter#144827) 2024-03-09 [email protected] Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849) 2024-03-09 [email protected] Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861) 2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855) 2024-03-08 [email protected] Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844) 2024-03-08 [email protected] Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176) 2024-03-08 [email protected] Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839) 2024-03-08 [email protected] Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790) 2024-03-08 [email protected] Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832) 2024-03-08 [email protected] Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677) 2024-03-08 [email protected] Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817) 2024-03-08 [email protected] Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 11, 2024
flutter/flutter@7c89ec8...3bb2e59 2024-03-11 [email protected] Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (flutter/flutter#144923) 2024-03-11 [email protected] Roll Flutter Engine from d13999c0ca79 to 210f84eb818b (1 revision) (flutter/flutter#144920) 2024-03-11 [email protected] Roll Flutter Engine from 7c2a56a44b41 to d13999c0ca79 (1 revision) (flutter/flutter#144907) 2024-03-10 [email protected] Rename isAvailableForEnvironment to isForEnvironment (#143176) (flutter/flutter#144858) 2024-03-10 [email protected] Roll Flutter Engine from f77664330122 to 7c2a56a44b41 (1 revision) (flutter/flutter#144894) 2024-03-10 [email protected] Roll Flutter Engine from 51fefde43cb3 to f77664330122 (1 revision) (flutter/flutter#144891) 2024-03-09 [email protected] Roll Flutter Engine from 49f01510e4e2 to 51fefde43cb3 (1 revision) (flutter/flutter#144889) 2024-03-09 [email protected] Roll Flutter Engine from 958d7cd560d2 to 49f01510e4e2 (1 revision) (flutter/flutter#144887) 2024-03-09 [email protected] Roll Flutter Engine from fc06f5a99377 to 958d7cd560d2 (2 revisions) (flutter/flutter#144884) 2024-03-09 [email protected] Roll Flutter Engine from 6f7fdc533490 to fc06f5a99377 (1 revision) (flutter/flutter#144876) 2024-03-09 [email protected] Roll Flutter Engine from 196132ffe2f8 to 6f7fdc533490 (1 revision) (flutter/flutter#144875) 2024-03-09 [email protected] Fix multiple calls to Slider's onChanged. (flutter/flutter#143680) 2024-03-09 [email protected] Roll Flutter Engine from d4e3d964dc8a to 196132ffe2f8 (1 revision) (flutter/flutter#144870) 2024-03-09 [email protected] Roll Flutter Engine from e79a72d362a7 to d4e3d964dc8a (1 revision) (flutter/flutter#144866) 2024-03-09 [email protected] Roll Flutter Engine from c3b70321be79 to e79a72d362a7 (1 revision) (flutter/flutter#144865) 2024-03-09 [email protected] Roll Flutter Engine from 79536627661a to c3b70321be79 (1 revision) (flutter/flutter#144864) 2024-03-09 [email protected] Roll Flutter Engine from 7541e902f1b4 to 79536627661a (2 revisions) (flutter/flutter#144863) 2024-03-09 [email protected] Roll Flutter Engine from 953927eae78b to 7541e902f1b4 (7 revisions) (flutter/flutter#144862) 2024-03-09 [email protected] Upgrade vm_service. (flutter/flutter#144845) 2024-03-09 [email protected] Replace dead links (flutter/flutter#144827) 2024-03-09 [email protected] Roll Flutter Engine from e099277ce061 to 953927eae78b (2 revisions) (flutter/flutter#144849) 2024-03-09 [email protected] Mark Mac_arm64_ios module_test_ios bringup: true (flutter/flutter#144861) 2024-03-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename isAvailableForEnvironment to isForEnvironment (#143176)" (flutter/flutter#144855) 2024-03-08 [email protected] Roll Flutter Engine from 05fdf947f81b to e099277ce061 (1 revision) (flutter/flutter#144844) 2024-03-08 [email protected] Rename isAvailableForEnvironment to isForEnvironment (flutter/flutter#143176) 2024-03-08 [email protected] Roll Flutter Engine from bc4abcda6357 to 05fdf947f81b (9 revisions) (flutter/flutter#144839) 2024-03-08 [email protected] Fixes the transition builder changing the Cupertino transition on Android. (flutter/flutter#134790) 2024-03-08 [email protected] Copy over source maps from dart2js target when they are enabled. (flutter/flutter#144832) 2024-03-08 [email protected] Marks Linux_android new_gallery_opengles_impeller__transition_perf to be unflaky (flutter/flutter#144677) 2024-03-08 [email protected] Roll Flutter Engine from bbb1ed00af49 to bc4abcda6357 (2 revisions) (flutter/flutter#144817) 2024-03-08 [email protected] Roll Packages from 6701c9e to 0badb43 (2 revisions) (flutter/flutter#144831) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 4 of a broken down version of the #140101 refactor.
This PR renames isAvailableForEnvironment to isForEnvironment and replaces a regular expression with a simple function. (The latter will change the behaviour for people with branch names like
mainly_refactorsorchess_master_experimentor whatever, but I'm pretty sure the old behaviour was not intended.)