Let Travis build the gallery and push to TestFlight / Play Store #14408
Conversation
|
Crap, not ready yet. Sharding AND specifying a different programming language (to get the Android SDK etc) is not trivial it seems. |
dev/bots/travis_script.sh
Outdated
|
|
||
| export PATH="$PWD/bin:$PWD/bin/cache/dart-sdk/bin:$PATH" | ||
|
|
||
| if [ "$SHARD" != "build_and_deploy_gallery" ]; then |
There was a problem hiding this comment.
this would probably be clearer if we flipped the if and else clauses around
dev/bots/travis_script.sh
Outdated
| fi | ||
|
|
||
| if [ "$TRAVIS_OS_NAME" = "linux" ] && \ | ||
| [ "$SHARD" = "docs" ]; then |
There was a problem hiding this comment.
let's put the if shard=docs thing in a chain with the if/else above, and then the os=linux check can go inside that if block
| int flutterVersionCode = Math.min(flutterVersionComponents[0].toInteger(), 99) * 10000000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[1].toInteger(), 99) * 100000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[2].toInteger(), 99) * 1000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[3]?.toInteger() ?: 0, 999) |
There was a problem hiding this comment.
zz will almost certainly be greater than 99 at some point
There was a problem hiding this comment.
also, nnn will always be 0 in the cases where we actually publish the gallery, right? if we only publish for dev or beta builds. So maybe we can remove the nnn case, and spread those digits to z and y.
There was a problem hiding this comment.
I shuffled the digits around just a bit. Unfortunately the play store is a bit yolo about stuff like this and the int value can only go up from this point.
I would also imagine that it should be possible to manually build and deploy from any point in time.
|
RSLGTM, I have no idea what the non-shell things are doing. |
80410fd to
01d17bd
Compare
…d. It's just a waste of bandwidth
1a5fe69 to
d0795cd
Compare
d0795cd to
dca0751
Compare
| int flutterVersionCode = Math.min(flutterVersionComponents[0].toInteger(), 20) * 100000000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[1].toInteger(), 99) * 1000000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[2].toInteger(), 999) * 1000 | ||
| flutterVersionCode += Math.min(flutterVersionComponents[3]?.toInteger() ?: 0, 999) |
There was a problem hiding this comment.
I'm seeing flutter run in flutter gallery failing on this line due to my version file having "unknown" instead of integer in flutterVersionComponents[3]:
╰─➤ cat $FH/flutter/version
0.0.0-unknown
╰─➤ $FH/flutter/bin/flutter doctor -v
[✓] Flutter (on Linux, locale en_US.UTF-8, channel master)
• Flutter version 0.0.0-unknown at $FH/flutter
There was a problem hiding this comment.
Can you flutter upgrade and show us the full result of flutter doctor again? I wasn't expecting this version format on the master branch.
…tter#14408) * iOS works * Works on Android * Take in commit number in iOS also. Get rid of image upload for Android. It's just a waste of bandwidth * Tweak to fix on Travis
#14306