Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove toggleableActiveColor from ThemeData #144178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

Remove toggleableActiveColor from ThemeData #144178

merged 2 commits into from
Feb 29, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Feb 26, 2024 •
edited
Loading

This PR is to remove deprecated ThemeData.toggleableActiveColor.

These parameters are made obsolete in #97972.
Part of #143956

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 26, 2024
@QuncCccccc QuncCccccc requested a review from Piinks February 27, 2024 18:30
@QuncCccccc QuncCccccc marked this pull request as ready for review February 27, 2024 18:30
@Piinks Piinks added c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Feb 28, 2024
Piinks
Piinks reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although there is a merge conflict from the other PR that just went in. :)

@QuncCccccc
Copy link
Contributor Author

Thanks a lot for your review. Will solve them!

@QuncCccccc QuncCccccc force-pushed the remove_toggeable_active_color branch from 4e3e658 to abfab0a Compare February 29, 2024 19:25
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Feb 29, 2024
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Feb 29, 2024

auto label is removed for flutter/flutter/144178, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@QuncCccccc QuncCccccc force-pushed the remove_toggeable_active_color branch from 95bce6e to 87fec79 Compare February 29, 2024 20:16
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024
@auto-submit auto-submit bot merged commit 1349c59 into flutter:master Feb 29, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2024
@engine-flutter-autoroll
1349c59 Remove toggleableActiveColor from ThemeData (flutter/flut…
bfa6c3e 
…ter#144178)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 1, 2024
@engine-flutter-autoroll
Roll Flutter from e92bca3 to ba719bc (37 revisions) (#6235)
8ccf7f6 
Roll Flutter from e92bca3 to ba719bc (37 revisions)

flutter/flutter@e92bca3...ba719bc

2024-03-01 [email protected] Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317)
2024-03-01 [email protected] Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319)
2024-03-01 [email protected] InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169)
2024-03-01 [email protected] Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468)
2024-03-01 [email protected] Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464)
2024-03-01 [email protected] Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459)
2024-03-01 [email protected] Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391)
2024-03-01 [email protected] Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457)
2024-03-01 [email protected] Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455)
2024-03-01 [email protected] Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453)
2024-03-01 [email protected] Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452)
2024-03-01 [email protected] Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450)
2024-03-01 [email protected] Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448)
2024-03-01 [email protected] Remove master from API docs (flutter/flutter#144425)
2024-03-01 [email protected] Enable missing-code-block-language (flutter/flutter#144443)
2024-03-01 [email protected] Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436)
2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424)
2024-02-29 [email protected] Reland [a11y] Fix date picker cannot focus on the edit field  (flutter/flutter#144198)
2024-02-29 [email protected] Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431)
2024-02-29 [email protected] Make daemon server work on ipv6-only machines. (flutter/flutter#144359)
2024-02-29 [email protected] Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079)
2024-02-29 [email protected] Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375)
2024-02-29 [email protected] Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423)
2024-02-29 [email protected] Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419)
2024-02-29 [email protected] Fix a crash in remote device daemon. (flutter/flutter#144358)
2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429)
2024-02-29 [email protected] Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178)
2024-02-29 [email protected] Add `FocusNode.focusabilityListenable` (flutter/flutter#144280)
2024-02-29 [email protected] Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416)
2024-02-29 [email protected] [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410)
2024-02-29 [email protected] Bump dartdocs to 8.0.6 (flutter/flutter#144413)
2024-02-29 [email protected] Use dartpad's main channel for master/main docs (flutter/flutter#144329)
2024-02-29 [email protected] Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405)
2024-02-29 [email protected] Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399)
2024-02-29 [email protected] Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395)
2024-02-29 [email protected] Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393)
2024-02-29 [email protected] Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from e92bca3 to ba719bc (37 revisions) (flutter#6235)
26fe4a3 
Roll Flutter from e92bca3 to ba719bc (37 revisions)

flutter/flutter@e92bca3...ba719bc

2024-03-01 [email protected] Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317)
2024-03-01 [email protected] Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319)
2024-03-01 [email protected] InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169)
2024-03-01 [email protected] Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468)
2024-03-01 [email protected] Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464)
2024-03-01 [email protected] Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459)
2024-03-01 [email protected] Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391)
2024-03-01 [email protected] Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457)
2024-03-01 [email protected] Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455)
2024-03-01 [email protected] Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453)
2024-03-01 [email protected] Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452)
2024-03-01 [email protected] Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450)
2024-03-01 [email protected] Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448)
2024-03-01 [email protected] Remove master from API docs (flutter/flutter#144425)
2024-03-01 [email protected] Enable missing-code-block-language (flutter/flutter#144443)
2024-03-01 [email protected] Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436)
2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424)
2024-02-29 [email protected] Reland [a11y] Fix date picker cannot focus on the edit field  (flutter/flutter#144198)
2024-02-29 [email protected] Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431)
2024-02-29 [email protected] Make daemon server work on ipv6-only machines. (flutter/flutter#144359)
2024-02-29 [email protected] Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079)
2024-02-29 [email protected] Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375)
2024-02-29 [email protected] Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423)
2024-02-29 [email protected] Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419)
2024-02-29 [email protected] Fix a crash in remote device daemon. (flutter/flutter#144358)
2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429)
2024-02-29 [email protected] Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178)
2024-02-29 [email protected] Add `FocusNode.focusabilityListenable` (flutter/flutter#144280)
2024-02-29 [email protected] Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416)
2024-02-29 [email protected] [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410)
2024-02-29 [email protected] Bump dartdocs to 8.0.6 (flutter/flutter#144413)
2024-02-29 [email protected] Use dartpad's main channel for master/main docs (flutter/flutter#144329)
2024-02-29 [email protected] Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405)
2024-02-29 [email protected] Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399)
2024-02-29 [email protected] Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395)
2024-02-29 [email protected] Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393)
2024-02-29 [email protected] Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@HansMuller HansMuller mentioned this pull request Mar 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
1349c59 Remove toggleableActiveColor from ThemeData (flutter/flut…
18421b3 
…ter#144178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: API break Backwards-incompatible API changes f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuncCccccc @Piinks