Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update some user-facing http links to https #14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Update some user-facing http links to https #14762

merged 1 commit into from
Feb 19, 2018

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Feb 18, 2018

These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.

Related read! https://krausefx.com/blog/trusting-sdks

These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.
@DanTup
Copy link
Contributor Author

DanTup commented Feb 19, 2018

@devoncarew I'm not sure what the normal workflow is here - I presume it's fine for me to merge? This change is pretty trivial, though for more complicated things are there guidelines on assigning reviews(/how many/etc.)?

@devoncarew
Copy link
Member

We can make sure that the right people are on the review (likely dependent on the content), and feel free to cc people who you know have context.

We shouldn't merge when the build system is red, except to address the breakage. It looks like there are some timeouts related to running tests on mac bots for the device lab; I'd wait to merge this until the breakage is resolved (the flutter-build check above is updated periodically for open PRs, so this PR will go green once the device lab bots are happy again).

@DanTup
Copy link
Contributor Author

DanTup commented Feb 19, 2018

the flutter-build check above is updated periodically for open PRs

I did wonder about that, thanks for the info!

@DanTup DanTup merged commit f914e70 into flutter:master Feb 19, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
These URLs all automatically redirect HTTP to HTTPS so makes sense to point users at the secure versions.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants