-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Make plugins work in Swift projects #15437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
await flutter('create', options: <String>['--org', 'io.flutter.devicelab', 'plugintest']); | ||
await flutter('create', options: <String>[ | ||
'--org', 'io.flutter.devicelab', | ||
'-${buildTarget[0]}', language, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but slightly magical - just so happens that the abbreviation of --android-language
(-a
) is also the first letter of the build target 'apk'... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit seems to have made plugin_test_win significantly flakier and made plugin_test_ios fail (that test has since been disabled). Do we know why? Are we planning on fixing the broken test any time soon or is it just wrong and we should just remove it? |
I upgraded cocoapods to 1.4.0 just now. |
When will this get to the beta channel? |
I get a similar error when trying to build a project that includes the
|
Hi, I think I'm running into this problem - but I can't be sure. I'm following this tutorial to add firestore to my flutter project. Running Swift on the iOS side - though in reality that was a 'just in case' situation, I haven't written any platform specific code. I'm getting the following errors having followed the above tutorial, and it seems to match the errors others have had.
Any ideas? Is this fixed? Mike |
@mikeashelby I wouldn't expect anyone reading comments on closed PRs. |
Enabling plugins in Swift iOS projects (#14667) and making Podfiles use symlinks (#14748) collided due to CocoaPods/CocoaPods#7463 which affects Swift projects with plugins only.
This PR adds a workaround for the CocoaPods issue to the project template's Swift Podfile.
Fixes #15099