-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Add minTileHeight
to ListTileTheme
#159053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads-up: minTileHeight
has already been added to the ListTile theme data.
flutter/packages/flutter/lib/src/material/list_tile_theme.dart
Lines 123 to 124 in d8ae99a
/// Overrides the default value of [ListTile.minTileHeight]. | |
final double? minTileHeight; |
The previous PR added this property to ListTileThemeData
without adding an obsolete property to ListTileTheme
.
This might be covered by #91772 where we are normalizing component themes to use *ThemeData, and I think @nate-thegrate has already pointed out this is included there. |
Hello! The
would be encouraged since this pattern follows Flutter widget theme convention:) |
I see. This PR just adds an obsolete property to ListTileTheme that can be used directly. I guess this is no longer needed for new properties :) |
We should not use these properties in ListTileTheme directly and the existing properties, except |
Thanks for sending a PR for this @AhmedLSayed9, I am going to close this PR based on the above comments. Please use ListTileThemeData.minTileHeight. Thanks! |
minTileHeight
was added by #145244 to ListTile widget so its height can be customized to less than the default height.This PR supports setting
minTileHeight
at the ListTileTheme too.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.