Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cutout rotation integration test #160255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Cutout rotation integration test #160255

wants to merge 20 commits into from

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Dec 13, 2024 •
edited
Loading

Test that the position of a cutout as reported by the Android engine repositions based on screen orientation.

Related to flutter/engine#55992

Part of #155658

to test run flutter drive integration_test/display_cutout_test.dart
from dev/integration_tests/display_cutout_rotation

TODO

  • Remove everything in native_driver_test
  • tune 5 second rotation wait time to something shorter.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@google-cla Google CLA
Copy link

google-cla bot commented Dec 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@reidbaker reidbaker mentioned this pull request Dec 13, 2024
Closed
9 tasks
gmackall
gmackall requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test for this will probably have to land in a different PR, I don't think we will be able to resolve CLA issues here

@reidbaker reidbaker closed this Dec 16, 2024
@reidbaker reidbaker deleted the i155658-rotation-cutout-test branch December 16, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmackall gmackall gmackall requested changes

@matanlurey matanlurey Awaiting requested review from matanlurey matanlurey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidbaker @gmackall @yaakovschectman