Apply suggestions from code review

Co-authored-by: Mouad Debbar <[email protected]>
flutter · auto-submit · Jun 3, 2025 · Jan 13, 2025 · Mar 21, 2025 · Mar 21, 2025
commit 3e19c278fa988beb6a5e41e9fd21b1e4f92d60d5
diff --git a/engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart b/engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/text_editing.dart
@@ -973,19 +973,17 @@ class EditingState {
   /// See also:
   ///
   ///  * [applyTextToDomElement], which is used for non-focused elements.
-  void applyToDomElement(DomHTMLElement? domElement, {bool isComposing = false}) {
+  void applyToDomElement(DomHTMLElement? domElement, {bool updateSelection = true}) {
     if (domElement != null && domElement.isA<DomHTMLInputElement>()) {
       final DomHTMLInputElement element = domElement as DomHTMLInputElement;
       element.value = text;
-      if (!isComposing) {
-        // If the user is composing, we should not update the selection range.
+      if (updateSelection) {
         element.setSelectionRange(minOffset, maxOffset);
       }
     } else if (domElement != null && domElement.isA<DomHTMLTextAreaElement>()) {
       final DomHTMLTextAreaElement element = domElement as DomHTMLTextAreaElement;
       element.value = text;
-      if (!isComposing) {
-        // If the user is composing, we should not update the selection range.
+      if (updateSelection) {
         element.setSelectionRange(minOffset, maxOffset);
       }
     } else {
@@ -1164,7 +1162,7 @@ class GloballyPositionedTextEditingStrategy extends DefaultTextEditingStrategy {
       // Set the last editing state if it exists, this is critical for a
       // users ongoing work to continue uninterrupted when there is an update to
       // the transform.
-      lastEditingState?.applyToDomElement(domElement, isComposing: isComposing);
+      lastEditingState?.applyToDomElement(domElement, updateSelection: !isComposing);
       // On Chrome, when a form is focused, it opens an autofill menu
       // immediately.
       // Flutter framework sends `setEditableSizeAndTransform` for informing
@@ -1215,7 +1213,7 @@ class SafariDesktopTextEditingStrategy extends DefaultTextEditingStrategy {
       // the transform.
       // If domElement is not focused cursor location will not be correct.
       moveFocusToActiveDomElement();
-      lastEditingState?.applyToDomElement(activeDomElement, isComposing: isComposing);
+      lastEditingState?.applyToDomElement(activeDomElement, updateSelection: !isComposing);
     }
   }
 
@@ -1473,7 +1471,7 @@ abstract class DefaultTextEditingStrategy
     if (!isEnabled || !editingState!.isValid) {
       return;
     }
-    lastEditingState!.applyToDomElement(domElement, isComposing: isComposing);
+    lastEditingState!.applyToDomElement(domElement, updateSelection: !isComposing);
   }
 
   void placeElement() {
@@ -1994,7 +1992,7 @@ class FirefoxTextEditingStrategy extends GloballyPositionedTextEditingStrategy {
     // Set the last editing state if it exists, this is critical for a
     // users ongoing work to continue uninterrupted when there is an update to
     // the transform.
-    lastEditingState?.applyToDomElement(activeDomElement, isComposing: isComposing);
+    lastEditingState?.applyToDomElement(activeDomElement, updateSelection: !isComposing);
   }
 }