[CP][Impeller] Move AHB check into Flutter main, don't disable ImageReader on 29. #164496
Conversation
…ageReader on 29. (flutter#164201) Rather than conditionally disabling AHBs, just disable Vulkan on devices where AHB imports don't work. FIx from last time is in the last commit, I reversed the string check accidentally and disabled vulkan everywhere 🥺 flutter#163473 flutter#160854
|
I will also take @jtmcdole override that we need a test. |
|
I only see one reference to 'mediatek' in the tree after this change: https://github.com/search?q=repo%3Aflutter%2Fflutter%20mediatek%20language%3AC%2B%2B%20&type=code _system_property* is provided by android, so I don't think this can be tested. @jonahwilliams to confirm. |
|
We can test it by running on a mediatek device ... which we have, its the mokey device in the lab. And if we ran our benchmarks on release branches we'd see that it is running GLES (for now). |
That works for me! |
9ae7906
into
flutter:flutter-3.29-candidate.0
…ble ImageReader on 29. (flutter/flutter#164496)
…ble ImageReader on 29. (flutter/flutter#164496)
…ble ImageReader on 29. (flutter/flutter#164496)
|
I bisected an issue I have down to this commit. The symptoms are the same as described in flutter-webrtc/flutter-webrtc#1756. But the original issue happened during the upgrade from 3.24 to 3.27 so it might not be directly related I'm currently doing more testing around vulkan/opengles to figure out which part of the changes triggered the issue. Does this behavior ring a bell? Or is this commit not supposed to cause something like this? |
|
ok, it takes the MediaTek branch on my device and uses the OpenGLES backend of Impeller since this commit. Forcing the backend to be vulkan via |
|
|
|
I filed a separate issue about this: #165976 |
…ble ImageReader on 29. (flutter/flutter#164496)
…eader on 29. (flutter#164496) Rather than conditionally disabling AHBs, just disable Vulkan on devices where AHB imports don't work. FIx from last time is in the last commit, I reversed the string check accidentally and disabled vulkan everywhere 🥺 flutter#163473 flutter#160854
Rather than conditionally disabling AHBs, just disable Vulkan on devices where AHB imports don't work. FIx from last time is in the last commit, I reversed the string check accidentally and disabled vulkan everywhere 🥺
#163473
#160854