Make LLDB check a warning instead of a failure #164828

vashworth · 2025-03-07T23:21:17Z

We added LLDB file in #164344. This adjusts it so if the LLDB file is missing it gives a warning rather than an error that fails the build.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma · 2025-03-10T20:51:39Z

packages/flutter_tools/lib/src/build_system/targets/ios.dart

@@ -503,11 +503,13 @@ abstract class IosLLDBInit extends Target {
    // an error.
    final String? srcRoot = environment.defines[kSrcRoot];
    if (srcRoot == null) {
-      throw MissingDefineException(kSdkRoot, name);
+      environment.logger.printError('Failed to find $srcRoot');
+      return;


Why change this one? It looks like the unpack ios target throws a missing define exception for this case too:

flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart

Lines 265 to 268 in cd433d4

final String? sdkRoot = environment.defines[kSdkRoot];

if (sdkRoot == null) {

throw MissingDefineException(kSdkRoot, name);

}

Just to be safe. Basically, if this target fails, we don't want it to stop the build.

Personally I would keep the exceptions for things that are unexpected and indicate a bug in our logic that we should investigate. I don't feel strongly though, feel free to keep as is.

loic-sharma · 2025-03-10T23:06:01Z

packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart

-          throwsToolExit(
-            message: 'Debugging Flutter on new iOS versions requires an LLDB Init File.',
-          ),
+          buffer.toString(),


Silly nit: could push the .toString() to capturedConsolePrint's implementation. This might be nice if we end up using capturedConsolePrint in more locations in the future. I don't feel strongly, feel free to skip

…tter#164828)

Make LLDB check a warning instead of a failure

9fcd4f2

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Mar 8, 2025

vashworth marked this pull request as ready for review March 10, 2025 14:31

vashworth requested a review from loic-sharma March 10, 2025 14:31

loic-sharma reviewed Mar 10, 2025

View reviewed changes

loic-sharma approved these changes Mar 10, 2025

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2025

auto-submit bot added this pull request to the merge queue Mar 10, 2025

Merged via the queue into flutter:master with commit 84b38b8 Mar 10, 2025
140 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

f5dbd29

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to b60d60a16673 (20 revisions) flutter/packages#8846

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

f1cabd3

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 39dc5717d599 (21 revisions) flutter/packages#8847

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

0a9486f

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 7bf883711647 (22 revisions) flutter/packages#8848

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

dc7c61d

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 9d2dcea4ab46 (23 revisions) flutter/packages#8849

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

e92cf27

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 463e7516406b (24 revisions) flutter/packages#8850

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

2711384

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 1cfbc3c10622 (25 revisions) flutter/packages#8851

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

9da80c1

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 11, 2025

Roll Flutter from b16430b2fd57 to 61a5fe792957 (26 revisions) flutter/packages#8852

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

64355ad

…tter#164828)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to eef31a1c2b73 (34 revisions) flutter/packages#8856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

dc50364

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

32d47e9

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

de3c9f7

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

af984c1

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

a1e2737

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

d4df2f4

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

d328427

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

9b773ca

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

c3969da

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

9d33976

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

5a29704

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

2189fad

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

98fa47a

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

de0b3bb

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

2df497e

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

f08daed

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

cde9759

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

81a677a

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

29d619d

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

978f346

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

4488250

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

fd49d94

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

819b124

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

1bd6445

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

a3bcbb4

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

5d9278b

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

ea028e8

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

5648e82

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

8a71588

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

e66cfbd

…tter#164828)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

84b38b8df Make LLDB check a warning instead of a failure (flutter/flu…

9e9b5f4

…tter#164828)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make LLDB check a warning instead of a failure #164828

Make LLDB check a warning instead of a failure #164828

Uh oh!

vashworth commented Mar 7, 2025 •

edited

Loading

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

vashworth Mar 10, 2025

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

loic-sharma Mar 10, 2025

Uh oh!

Uh oh!

Uh oh!

	final String? sdkRoot = environment.defines[kSdkRoot];
	if (sdkRoot == null) {
	throw MissingDefineException(kSdkRoot, name);
	}

Make LLDB check a warning instead of a failure #164828

Make LLDB check a warning instead of a failure #164828

Uh oh!

Conversation

vashworth commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vashworth commented Mar 7, 2025 •

edited

Loading