-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Clarify performacne of SingleTickerProviderStateMixin vs TickerProviderStateMixin #164870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the code, I can be sure this statement is true.
Using one [TickerProviderStateMixin] twice is more efficient than two [SingleTickerProviderStateMixin]s
@@ -301,6 +301,8 @@ mixin SingleTickerProviderStateMixin<T extends StatefulWidget> on State<T> | |||
/// If you only have a single [Ticker] (for example only a single | |||
/// [AnimationController]) for the lifetime of your [State], then using a | |||
/// [SingleTickerProviderStateMixin] is more efficient. This is the common case. | |||
/// Using one [TickerProviderStateMixin] twice is more efficient than two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When creating multiple [AnimationController]s, using a single state with [TickerProviderStateMixin] as vsync for all [AnimationController]s is more efficient than creating multiple states with [SingleTickerProviderStateMixin].
and there should be a new line in between this and previous paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there is trailing space
|
Should be fixed now. |
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…ckerProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
…erProviderStateMixin (flutter/flutter#164870)
Adds the following line to TickerProviderStateMixin:
This is based on a discussion on Flutter Discord with @chunhtai. From what I understood, creating multiple
SingleTickerProviderStateMixin
s is more expensive because you need two different state which is relatively costly compared to having just one. Not sure if this line should should be qualified like "Using one [TickerProviderStateMixin] twice is generally more efficient than two [SingleTickerProviderStateMixin]s" or similar.This change should be reviewed for correctness as I don't actually understand enough about the difference between
TickerProviderStateMixin
andSingleTickerProviderStateMixin
.Closes #164869
Example case where this was relevant (click)
I was avoiding using
TickerProviderStateMixin
like so:Instead of just:
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.