[CP] Change fallback behavior for devices pre API 29 to Skia regardless of Impeller state. #165090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
@reidbaker - I don't know if I have any goodwill tokens to burn, but this would be one to burn it on.
reidbaker
approved these changes
Mar 13, 2025
70bd597
into
flutter:flutter-3.29-candidate.0
150 checks passed
|
Accepted but I need a changelog entry from yall |
|
on it |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
…a regardless of Impeller state. (flutter/flutter#165090)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
…a regardless of Impeller state. (flutter/flutter#165090)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
…a regardless of Impeller state. (flutter/flutter#165090)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 3, 2025
…a regardless of Impeller state. (flutter/flutter#165090)
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
…ss of Impeller state. (flutter#165090) CP of flutter#165075 > There are currently a large amount of crashes coming from older devices that we don't have good test coverage for. For now, lets remove the fallback to ImpellerGLES on old devices and instead use SkiaGLES, which we know from experience works on these older devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP of #165075