[dart:ui] Add Path.addRSuperellipse (alternative) #166167
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Path.addRSuperellipse
todart:ui
. This is needed to implement a parity class toRoundedRectangleBorder
as discussed here.An alternative to #166045, this PR does not diverge at the
dl_builder
level, but simply implements pathing for bothdart:ui
andimpeller::PathBuilder::addRSuperellipse
with the same code. This avoids theDrawRSuperellipse
op having varying size depending on drawing style, although it doesn't have the benefit that @/jonahwilliams hoped to calculate the path less frequently.I think this is a better approach for its simpleness. If we want to calculate tessellation/path less frequently, we might want to do it in a grander scale for all shapes in a separate PR.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.