[Impeller] if drawTextFrame scale is massive, convert to Path. #166234

jonahwilliams · 2025-03-31T00:29:16Z

If the text scale gets too big, its faster (and higher res) to switch to path rendering than to keep using the glyph atlas cache.

jonahwilliams · 2025-04-03T01:19:51Z

Marking ready for goldens.

flutter-dashboard · 2025-04-03T02:32:28Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166234 at sha ad4b6f4

jonahwilliams · 2025-04-03T15:12:36Z

@gaaclarke obvs this changes some of the existing golden tests. Should I add some overrides so we keep using the atlas for them?

gaaclarke

Looking good. Give me a sec to think about what we want to do about testing.

gaaclarke · 2025-04-03T15:46:17Z

engine/src/flutter/impeller/display_list/aiks_dl_text_unittests.cc

+TEST_P(AiksTest, MassiveScaleConvertToPath) {
+  DisplayListBuilder builder;
+  DlPaint paint;
+  paint.setColor(DlColor::ARGB(1, 0.1, 0.1, 0.1));
+  builder.DrawPaint(paint);
+  builder.Scale(16, 16);
+  RenderTextInCanvasSkia(
+      GetContext(), builder, "HELLO", "Roboto-Regular.ttf",
+      TextRenderOptions{.font_size = 16, .position = DlPoint(0, 20)});
+
+  ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
+}


It would be nice to have a scale slider on here so that we can see the transition from raster to vector, to make sure it isn't too jarring.

It looks good? Unfortunately there is no good way to check with goldens.

gaaclarke · 2025-04-03T15:47:06Z

engine/src/flutter/impeller/display_list/canvas.cc

+  // This is a somewhat arbitrary cutoff to switch from rasterized glyphs
+  // to path rendering, for both performance and fidelity purposes.
+  Scalar max_scale = GetCurrentTransform().GetMaxBasisLengthXY();
+  if (max_scale * text_frame->GetFont().GetMetrics().point_size > 250) {


Pull out 250 to it's own constant.

gaaclarke · 2025-04-03T15:54:11Z

engine/src/flutter/impeller/typographer/backends/skia/text_frame_skia.cc

+  return std::make_shared<TextFrame>(
+      runs, ToRect(blob->bounds()), has_color, [blob]() {
+        SkPath path = skia::textlayout::Paragraph::GetPath(blob.get());
+        SkPath transformed = path.makeTransform(
+            SkMatrix::Translate(blob->bounds().left(), blob->bounds().top()));
+        return flutter::DlPath(transformed);
+      });


Suggested change

return std::make_shared<TextFrame>(

runs, ToRect(blob->bounds()), has_color, [blob]() {

SkPath path = skia::textlayout::Paragraph::GetPath(blob.get());

SkPath transformed = path.makeTransform(

SkMatrix::Translate(blob->bounds().left(), blob->bounds().top()));

return flutter::DlPath(transformed);

});

return std::make_shared<TextFrame>(

runs, ToRect(blob->bounds()), has_color, make_lazy([blob]() {

SkPath path = skia::textlayout::Paragraph::GetPath(blob.get());

SkPath transformed = path.makeTransform(

SkMatrix::Translate(blob->bounds().left(), blob->bounds().top()));

return flutter::DlPath(transformed);

}));

nit: If we formally make a type for LazyValue<T> that would better communicate the usage semantics of the closure we are passing into the TextFrame constructor. It also gives us the opportunity to memoize the result.

gaaclarke · 2025-04-03T15:57:41Z

engine/src/flutter/impeller/typographer/text_frame.h

 namespace impeller {

+using PathCreator = std::function<std::optional<flutter::DlPath>()>;


The return type shouldn't be an optional. The one instance we have of it it always returns a path. If we want to communicate that it can error, we should use fml::StatusOr<flutter::DlPath>.

Its not an error for a glyph to not have a path though. Emojis for example do not have a path as they are bitmaps.

In all of our code we are returning a path though. Not having a callback is interpreted to mean there is no path. With the optional we have double ways of specifying that concept, nullptr callback and returning an std::optional (which we don't do).

hmm, I see.

You forgot to update this.

gaaclarke · 2025-04-03T15:58:29Z

engine/src/flutter/impeller/typographer/text_frame.h

+namespace flutter {
+class DlPath;
+}


We should have an include for this: https://google.github.io/styleguide/cppguide.html#Forward_Declarations

We can't as it creates a cycle

Dependency cycles are worth breaking up since it changes code that can be understood in a hierarchy into a big ball. Cyclical dependencies can be broken up by introducing a 3rd entity that contains the thing both of them need (instead of getting it from each other).

I understand that, but embarking on a refactor of the impeller and display-list sources is way out of scope for what we're doing at this point in the project.

Your call. I just wanted to make sure you knew it was a problem and how to fix it. If it isn't something that's easy to do we can file an issue.

Add a TODO() linking the issue.

gaaclarke

Here's what I think we should do about testing. Let's create a golden test that draws the string "lo" at many different scales / font size such that we get a good sampling from the path renderer and the raster renderer.

By drawing 2 characters we can have better confidence that we aren't messing up spacing. That's what one of those changed tests was for.

We have no way of knowing at the test which was used. By drawing a lot of different scales we can get reassurance that we have coverage of both of them.

If we have that test I don't think we need to care about the changed tests or create some mechanism to force path/raster.

gaaclarke · 2025-04-03T16:11:17Z

Maybe it will be hard to fit that all into one golden since the paths glyphs need to much real estate. I guess we could split it up if we had to.

jonahwilliams · 2025-04-03T22:15:04Z

@gaaclarke sorry not following 100%. Do you want me to add an option to force path/raster renderer - or were you more looking for a golden that renders a continuity of glyphs from raster to path?

gaaclarke · 2025-04-03T22:38:58Z

@gaaclarke sorry not following 100%. Do you want me to add an option to force path/raster renderer - or were you more looking for a golden that renders a continuity of glyphs from raster to path?

I'm thinking like this. That way the test doesn't need to force path/raster because we have the whole continuity represented. So if we break one of them it should show up here. And if we change the threshold for some reason the test won't become obsolete and lose coverage.

flutter-dashboard · 2025-04-04T01:48:58Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166234 at sha 5911a3a

gaaclarke

The new test looks good. I'm fine punting on fixing the cyclical dependency if it isn't an easy fix.

gaaclarke · 2025-04-04T17:09:39Z

engine/src/flutter/impeller/display_list/aiks_dl_text_unittests.cc

@@ -858,5 +872,31 @@ TEST_P(AiksTest, SingleIconShadowTest) {
            1u);
 }

+TEST_P(AiksTest, LoAndBehold) {


Needs a comment or more descriptive name haha.

gaaclarke · 2025-04-04T17:15:36Z

engine/src/flutter/impeller/typographer/text_frame.h

+namespace flutter {
+class DlPath;
+}


Add a TODO() linking the issue.

gaaclarke · 2025-04-04T17:16:29Z

engine/src/flutter/impeller/typographer/text_frame.h

 namespace impeller {

+using PathCreator = std::function<std::optional<flutter::DlPath>()>;


You forgot to update this.

gaaclarke · 2025-04-04T17:20:14Z

engine/src/flutter/impeller/display_list/aiks_dl_text_unittests.cc

+TEST_P(AiksTest, LoAndBehold) {
+  DisplayListBuilder builder;
+  DlPaint paint;
+  paint.setColor(DlColor::ARGB(1, 0.1, 0.1, 0.1));


You need to scale by the content scalar too to fix the golden images.

Why do we need to add an additional scale - the transform I'm using below is just multiplied by the ctm?

DPI differences between CI and running locally. The CTM is wrong for goldens on CI that run at 1px = 1 logical px. Something is obviously weird since running goldens locally gives the wrong scale. If we follow the convent though everything works so we haven't prioritized investigating further.

gaaclarke

lgtm (modulo the scale on the golden images)

flutter/flutter#166234)

Manual roll requested by [email protected] flutter/flutter@02f13c3...212064a 2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925) 2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496) 2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by [email protected] flutter/flutter@02f13c3...212064a 2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925) 2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496) 2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…(#9036) Manual roll requested by [email protected] flutter/flutter@02f13c3...212064a 2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925) 2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 [email protected] Roll Packages from 95f8e65 to 57f42e1 (2 revisions) (flutter/flutter#166583) 2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496) 2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#166234)

[Impeller] if drawTextFrame scale is massive, convert to Path.

7543f7e

github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 31, 2025

jonahwilliams added 4 commits April 1, 2025 10:12

update expectation.

472394f

add test.

74af8e3

Merge branch 'main' of github.com:flutter/flutter into convert_to_pat

c98d25b

use font pt size.

ad4b6f4

jonahwilliams marked this pull request as ready for review April 3, 2025 01:19

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 3, 2025

jonahwilliams requested a review from gaaclarke April 3, 2025 15:12

gaaclarke reviewed Apr 3, 2025

View reviewed changes

gaaclarke requested changes Apr 3, 2025

View reviewed changes

++

91728ab

++

5911a3a

++

149fa75

jonahwilliams requested a review from gaaclarke April 4, 2025 17:05

gaaclarke reviewed Apr 4, 2025

View reviewed changes

jonahwilliams mentioned this pull request Apr 4, 2025

[Impeller] cyclical dependencies between impeller, display_list, typographer #166593

Closed

more adjustments.

c66c929

gaaclarke approved these changes Apr 4, 2025

View reviewed changes

++

2b21888

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

0e15900

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

bca13c5

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 7, 2025

Roll Flutter from 02f13c37841f to 510875c82baa (33 revisions) flutter/packages#9022

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

e2e908a

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 7, 2025

Roll Flutter from 02f13c37841f to 86525bcce49e (34 revisions) flutter/packages#9023

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

128357f

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to fd42f34d76f9 (48 revisions) flutter/packages#9026

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

517761b

flutter/flutter#166234)

This was referenced Apr 8, 2025

Roll Flutter from 02f13c37841f to ca3788316551 (49 revisions) flutter/packages#9027

Closed

Roll Flutter from 02f13c37841f to 6fc673fc3632 (50 revisions) flutter/packages#9028

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

bddc37f

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

c67e6d8

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to 4a3d13eb174f (51 revisions) flutter/packages#9029

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

a2c747b

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to 9bf18f097137 (53 revisions) flutter/packages#9030

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

2c05802

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 8, 2025

Roll Flutter from 02f13c37841f to 30e53b0d9caa (54 revisions) flutter/packages#9031

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

a23c8d9

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

6e5c4d3

flutter/flutter#166234)

engine-flutter-autoroll mentioned this pull request Apr 9, 2025

Manual roll Flutter from 02f13c37841f to 212064a3e558 (21 revisions) flutter/packages#9036

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

df39df0

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

f23ec40

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

aa39f66

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

cfe716d

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

dfc204c

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

996a01c

flutter/flutter#166234)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

f00d387 [Impeller] if drawTextFrame scale is massive, convert to Path. (

0ecdecc

flutter/flutter#166234)

		namespace impeller {

		using PathCreator = std::function<std::optional<flutter::DlPath>()>;

[Impeller] if drawTextFrame scale is massive, convert to Path. #166234

[Impeller] if drawTextFrame scale is massive, convert to Path. #166234

Uh oh!

Conversation

jonahwilliams commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams commented Apr 3, 2025

Uh oh!

flutter-dashboard bot commented Apr 3, 2025

Uh oh!

jonahwilliams commented Apr 3, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Apr 3, 2025

Uh oh!

jonahwilliams commented Apr 3, 2025

Uh oh!

gaaclarke commented Apr 3, 2025

Uh oh!

flutter-dashboard bot commented Apr 4, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Mar 31, 2025 •

edited

Loading

gaaclarke Apr 3, 2025 •

edited

Loading

gaaclarke Apr 3, 2025 •

edited

Loading