-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Convert Gradle buildscripts of Android plugin templates from Groovy to Kotlin #166312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Convert Gradle buildscripts of Android plugin templates from Groovy to Kotlin #166312
Conversation
c15e48e
to
89657a7
Compare
89657a7
to
bcd10f1
Compare
failures seem to be caused by: |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hi @bartekpacia is this something you're still pursuing? |
Hey! Yes, I gotta fix the CI failures, didnt have much time recently |
Hi, Just letting you know there are some changes required for this to work: (changes need to be made on all versions) flutter/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.kts.tmpl Lines 35 to 42 in 4a36165
kotlinOptions {
jvmTarget = JavaVersion.VERSION_11.toString()
}
sourceSets {
getByName("main").java.srcDir("src/main/kotlin")
getByName("test").java.srcDir("src/test/kotlin")
} flutter/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.kts.tmpl Lines 53 to 63 in 4a36165
testOptions {
unitTests.all {
it.useJUnitPlatform()
it.testLogging {
events("passed", "skipped", "failed", "standardOut", "standardError")
it.outputs.upToDateWhen { false }
showStandardStreams = true
}
}
} I can't get to import on Gradle sync pluginManagement {
repositories {
google()
mavenCentral()
gradlePluginPortal()
}
} and replacing flutter/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.kts.tmpl Lines 23 to 24 in 4a36165
plugins {
id("com.android.library") version "{{agpVersion}}"
id("org.jetbrains.kotlin.android") version "{{kotlinVersion}}"
} This one could be an issue on my part, I'm not sure (Gradle doesn't want to fetch the plugins from Maven repos if they are not defined in |
Resolve #142685
Pre-launch Checklist
///
).