Fix Linux OpenGL compositor on ARM driver#166753
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
robert-ancell
left a comment
There was a problem hiding this comment.
Thanks, should be good to land with the above changes. If anyone can investigate futher it would be good to know why blit is having so many issues, are we using it wrong in some way?
|
@robert-ancell I agree that the implementation using blit should be investigated further. |
|
I added it to the autosubmit queue. But this might need to be rebased and submitted again. |
|
autosubmit label was removed for flutter/flutter/166753, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
|
autosubmit label was removed for flutter/flutter/166753, because Pull request flutter/flutter/166753 is not in a mergeable state. |
Fix Linux OpenGL compositor on ARM driver.
Add "ARM" to the list of drivers unsupported by the gl_framebuffer_blit based rendering.
#152099
Pre-launch Checklist
///).