Fix outdated reference to material in WidgetStateMapper's error message #166816
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| 'None of the provided map keys matched this set, ' | ||
| 'and the type "$T" is non-nullable.\n' | ||
| 'Consider using "WidgetStateProperty<$T?>.fromMap()", ' | ||
| 'Consider using "WidgetStateMapper<$T?>()", ' |
There was a problem hiding this comment.
Can you explain this change here?
There was a problem hiding this comment.
It just felt weird that WidgetStateMapper was recommending WidgetStateProperty.fromMap even though it’s inside WidgetStateMapper, they both did the same thing, and fromMap is more verbose.
No strong opinion on it though, I can revert this.
There was a problem hiding this comment.
Got it. I say keep it. Thanks for explaining.
| 'None of the provided map keys matched this set, ' | ||
| 'and the type "$T" is non-nullable.\n' | ||
| 'Consider using "WidgetStateProperty<$T?>.fromMap()", ' | ||
| 'Consider using "WidgetStateMapper<$T?>()", ' |
There was a problem hiding this comment.
Got it. I say keep it. Thanks for explaining.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.