-
Notifications
You must be signed in to change notification settings - Fork 28.5k
[Web][Engine] Update MediaQuery in response to semanticsEnabled #166836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
3d7aacd
to
ac81fa4
Compare
ac81fa4
to
630eeea
Compare
175792d
to
ae1a837
Compare
ae1a837
to
c80b0bf
Compare
2a38171
to
3314962
Compare
1e9987a
to
fdea76b
Compare
fdea76b
to
034e48f
Compare
ab9a59c
to
4b1f494
Compare
496e3a7
to
1995455
Compare
1995455
to
a51f4c5
Compare
@@ -2485,6 +2485,10 @@ class EngineSemantics { | |||
final PlatformConfiguration newConfiguration = EnginePlatformDispatcher.instance.configuration | |||
.copyWith(accessibilityFeatures: original.copyWith(accessibleNavigation: value)); | |||
EnginePlatformDispatcher.instance.configuration = newConfiguration; | |||
Future.microtask(() { | |||
// Avoid executing MediaQuery._updateData during build time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done in MediaQuery
since web engine doesn't know (also shouldn't care ) about the build phase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we may run into same issue after thread merged in mobile, so it is best to handle this in framework side
fix #134980
Calling
EnginePlatformDispatcher.instance.invokeOnAccessibilityFeaturesChanged();
afterEnginePlatformDispatcher.instance.configuration = newConfiguration
to notify update configuration event toMediaQuery
.before
main.mov
after
fixed.mov
Example Code
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.