-
Notifications
You must be signed in to change notification settings - Fork 28.5k
WIP: FFI based multi-window support #167393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
72861c6
to
ca898d1
Compare
688b605
to
bdb42d7
Compare
To use a custom class MyBinding extends WidgetsFlutterBinding {
static late final _instance = MyBinding();
static MyBinding ensureInitialized() => _instance;
@override
WindowingOwner createWindowingOwner() {
return FlutterpiWindowingOwner();
}
} And then how do you make use of that? Call |
602ca43
to
fce7191
Compare
All good 👍 my concern would've just been that that makes it harder for apps to use custom widgets bindings. Other than that I actually like the approach of handling embedder-specific stuff in the bindings |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.