Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the SliverTree scrolling rendering issue. #167921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

Fix the SliverTree scrolling rendering issue. #167921

merged 2 commits into from
May 1, 2025
+47 −2

Conversation

yiiim
Copy link
Member

@yiiim yiiim commented Apr 28, 2025

Fixes: #153149

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Apr 28, 2025
@yiiim yiiim requested a review from Piinks April 28, 2025 15:06
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167921 at sha de69972

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 28, 2025
Piinks
Piinks approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thank you again @yiiim! LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 1, 2025
Merged via the queue into flutter:master with commit 3b924ea May 1, 2025
77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
cc7e5e1 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
69ccd90 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
69524c7 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
bca7205 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
db278d1 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
a44629a 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
4c06c46 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
a24b84e 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
3717e13 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
283bcbe 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
b0e93a6 
…ter#167921)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
5fa4dfa 
…ter#167921)
@Piinks Piinks mentioned this pull request May 2, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
14e2e5a 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
97c4592 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
594a675 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
2a60298 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
cfd21e3 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
c04959c 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
fc5a032 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
ce06122 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
022c0c8 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
dc430c9 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
ff8ca59 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
b159a32 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
e3b58b2 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
0d0ef0e 
…ter#167921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
3b924ea26 Fix the SliverTree scrolling rendering issue. (flutter/flut…
00d0362 
…ter#167921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeSliver data disappears when scrolling
2 participants
@yiiim @Piinks