Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Declare both Mac and iOS build arguments in apple_sdk.gni #168025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Declare both Mac and iOS build arguments in apple_sdk.gni #168025

merged 1 commit into from
Apr 30, 2025
+38 −45

Conversation

jason-simmons
Copy link
Member

Without this the Flutter GN wrapper script warns about undeclared variables.

@jason-simmons
Declare both Mac and iOS build arguments in apple_sdk.gni
df15cc8 
Without this the Flutter GN wrapper script warns about undeclared variables.
@jason-simmons jason-simmons requested a review from cbracken April 29, 2025 23:42
@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Apr 29, 2025
cbracken
cbracken approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 30, 2025

autosubmit label was removed for flutter/flutter/168025, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 30, 2025
Merged via the queue into flutter:master with commit 83a94d9 Apr 30, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
9ad1fc8 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
70ddeeb 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
776bc85 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
bed0ed2 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
fbb4a0d 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
05300cc 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
6869c39 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
2a916d2 
…lutter/flutter#168025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
b8ecf65 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
37fca46 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
32729a9 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
2094697 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
09b6e02 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
e5e5742 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
578c160 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
8551f5d 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
c60490c 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
3104998 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
ebae5b5 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
d9e1795 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
b9a7bfc 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
19768a7 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
708e841 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
0b1b8d3 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
53176f4 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
3e79ad5 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
7b8e1c5 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
fec3b1c 
…lutter/flutter#168025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
83a94d905 Declare both Mac and iOS build arguments in apple_sdk.gni (f…
0e7fa04 
…lutter/flutter#168025)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-simmons @cbracken