Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Impeller] Use the stroke width in the coverage calculation for CircleGeometry #168030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

[Impeller] Use the stroke width in the coverage calculation for CircleGeometry #168030

merged 1 commit into from
May 1, 2025

Conversation

jason-simmons
Copy link
Member

No description provided.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 30, 2025
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #168030 at sha 3f22d2a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 30, 2025
jonahwilliams
jonahwilliams approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented May 1, 2025

autosubmit label was removed for flutter/flutter/168030, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 1, 2025
Merged via the queue into flutter:master with commit c3e0212 May 1, 2025
182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
dce4c1e 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
5f5ce3a 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
669460b 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
752d937 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
d269423 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
fb9eaee 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
28dc000 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
0e96ca0 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
d6af01e 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
e8522fe 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
b18d452 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
8c213e7 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
ca4ae77 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
abc8f91 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
8a7e3fe 
… for CircleGeometry (flutter/flutter#168030)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
c9e0c56 
… for CircleGeometry (flutter/flutter#168030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
6fa4bcb 
… for CircleGeometry (flutter/flutter#168030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
16e2680 
… for CircleGeometry (flutter/flutter#168030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
4de7f01 
… for CircleGeometry (flutter/flutter#168030)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c3e02128c [Impeller] Use the stroke width in the coverage calculation…
6fa299b 
… for CircleGeometry (flutter/flutter#168030)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@jason-simmons @mboetger
[Impeller] Use the stroke width in the coverage calculation for Circl…
94651b6 
…eGeometry (flutter#168030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jason-simmons @jonahwilliams