Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CP][Impeller] report application version info as 2.0 #168086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

[CP][Impeller] report application version info as 2.0 #168086

merged 1 commit into from
Apr 30, 2025

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Apr 30, 2025 •
edited
Loading

Cherry pick of #167961

@jonahwilliams
[Impeller] report application version info as 2.0 (flutter#167961)
346a223 
Update the reported engine so we can distinguish 3.27 engines from
(eventually) newer engines.
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 30, 2025
matanlurey
matanlurey approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This won't make it into 3.32.0-0.3.pre which is going out ~today, but the next beta - is that OK?

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@jonahwilliams
Copy link
Member Author

Yup that is fine, just needs to make it to the stable

@auto-submit auto-submit bot merged commit a5ca02f into flutter:flutter-3.32-candidate.0 Apr 30, 2025
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @matanlurey