Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove engine tests kvm=1 as unnecessary. #168106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

Remove engine tests kvm=1 as unnecessary. #168106

merged 3 commits into from
May 1, 2025
+0 −8

Conversation

matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Apr 30, 2025 •
edited
Loading

Related to #168087, but not related to release build orchestrators.

Presubmit (in theory) proved this is safe to land.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Apr 30, 2025
@matanlurey matanlurey changed the title Remove kvm=1 as unnecessary. Remove engine tests kvm=1 as unnecessary. Apr 30, 2025
@matanlurey matanlurey requested a review from zanderso April 30, 2025 23:09
@matanlurey matanlurey marked this pull request as ready for review April 30, 2025 23:09
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 30, 2025

autosubmit label was removed for flutter/flutter/168106, because - The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2025
zanderso
zanderso reviewed May 1, 2025
View reviewed changes
engine/src/flutter/ci/builders/linux_fuchsia_tests.json
@@ -234,7 +234,6 @@
"cas_archive": false,
"drone_dimensions": [
"device_type=none",
"kvm=1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only removing here and not in the rest of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional. Updated.

@matanlurey matanlurey force-pushed the experiment-remove-ci-kvm branch from 4a34764 to 7e2138a Compare May 1, 2025 20:56
@matanlurey matanlurey requested a review from zanderso May 1, 2025 20:56
@matanlurey matanlurey added this pull request to the merge queue May 1, 2025
Merged via the queue into flutter:master with commit 1134d4b May 1, 2025
178 of 179 checks passed
@matanlurey matanlurey deleted the experiment-remove-ci-kvm branch May 1, 2025 23:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
ae09210 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
1aaf675 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
bb64e64 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
b90cf2f 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
218e41f 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
1184bf1 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
5f72aeb 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
2dacdeb 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
70c5347 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
a0b8a56 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
879dcad 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
a804487 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
b645dc0 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
e897744 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
2d91491 
…r#168106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
87ec177 
…r#168106)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
61f1de3 
…r#168106)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
5c00362 
…r#168106)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
adfba2e 
…r#168106)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
1134d4b47 Remove engine tests kvm=1 as unnecessary. (flutter/flutte…
611272a 
…r#168106)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@matanlurey @mboetger
Remove engine tests kvm=1 as unnecessary. (flutter#168106)
30bfcc3 
Related to flutter#168087, but not
related to release build orchestrators.

Presubmit (in theory) proved this is safe to land.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matanlurey @zanderso