Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Increased the limit where we start chopping off the end of blurs #168109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Increased the limit where we start chopping off the end of blurs #168109

wants to merge 3 commits into from
+5 −5

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Apr 30, 2025 •
edited
Loading

issue: #165422

Here is the before/after screenshots at sigma = 30

beforeafter.mp4

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 30, 2025
@gaaclarke gaaclarke requested review from jonahwilliams and flar April 30, 2025 22:40
flar
flar approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with comment nit...

engine/src/flutter/impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
// Chop off the last samples if the radius >= 3 where they account for < 1.56%
// of the result.
// Chop off the last samples if the radius >= 16 where they account for
// < 1.56% of the result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still 1.56% if you increase the radius size? I would think that the contribution %age would go way down at that radius.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't measure it, that's from the article on the lerp hack. I think it's probably still a good rule of thumb, it obviously isn't going to be exact for every radius.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the comment to reflect it isn't exactly 1.56%

@gaaclarke gaaclarke force-pushed the increase-blur-radius branch from 8196ef5 to dcad843 Compare May 2, 2025 16:37
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented May 2, 2025

autosubmit label was removed for flutter/flutter/168109, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke force-pushed the increase-blur-radius branch 2 times, most recently from 8c807e0 to a327427 Compare May 5, 2025 21:32
@gaaclarke
Copy link
Member Author

I'm having a hard time getting this through CI. I'm getting failures in things like testKeyboardAnimationWillWaitUIThreadVsync which is hard to believe it could be related to this change. I'll keep trying rebasing for now.

@gaaclarke gaaclarke force-pushed the increase-blur-radius branch from a327427 to 0df4796 Compare May 5, 2025 23:51
@gaaclarke gaaclarke force-pushed the increase-blur-radius branch from 0df4796 to 6728ad9 Compare May 6, 2025 16:33
@gaaclarke
Copy link
Member Author

This is failing because of changes to golden images in the bespoke platform view golden tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flar flar flar approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @flar