Android home/end keyboard shortcut support #168184
Open
+375
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s tests. The shortcuts tests that I wrote only covered Android and Linux, but this commit expands them to all platforms. I discovered some missing Linux shortcuts in the process, which when testing my Linux machine (gedit) seem like they should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Home and End keyboard shortcuts on Android. It seems like we had mistakenly purposely disabled them on Android before (or maybe native Android recently added support for them?).
In the process I also noticed that Linux was missing home/end+control shortcuts, so I added them. I confirmed that these are supported natively using my Linux machine.
Fixes #168183