Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace [FinderBase] with [Finder] in the documentation of Matchers #168279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace [FinderBase] with [Finder] in the documentation of Matchers #168279

wants to merge 1 commit into from
+5 −5

Conversation

ahmedsameha1
Copy link

Replace [FinderBase] with [Finder] in the doc comments of Matchers.

This is my try to fix #168230

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels May 3, 2025
@ahmedsameha1 ahmedsameha1 mentioned this pull request May 3, 2025
Open
justinmc
justinmc reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it more accurate to say FinderBase instead of Finder? Something like findsNothing could be used with SemanticsFinder, which is a FinderBase and not a Finder.

Edit: In your example in the issue #168230, you compare findsNothing with findsOneWidget, but findsOneWidget should operate only on Finders, so I think that is correct as-is.

@ahmedsameha1
Copy link
Author

I cannot understand you. Both FindsNothing and FindsOneWidget are instances of the same class: _FindsCountMatcher, so if something should work with one, it should work with the other, and if something should not work with one, it should not work with the other.
Ok. I could replace [Finder] with [FinderBase]. There is more than one subtype of FinderBase, so I think that you are correct that I should replace [Finder] with [FinderBase]. May I update this pull request according to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedsameha1 @justinmc