Respect calendarDelegate in showDateRangePicker and make CalendarDateRangePicker public
#168290
+52
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalendarDateRangePicker public
CalendarDateRangePicker publiccalendarDelegate in showDateRangePicker and make CalendarDateRangePicker public
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
calendarDelegateparameter was not respected byshowDateRangePicker. Although support forcalendarDelegatewas added in PR #161874, it was inadvertently omitted fromshowDateRangePicker, causing inconsistencies in behavior compared toshowDatePicker.Also, to align with the existing public
CalendarDatePickerclass,CalendarDateRangePickerhas been made public. This ensures consistency in API surface and allows users to build custom range pickers with full access to the base widget.Pre-launch Checklist
///).