[Android] add abiFilters to Flutter Gradle Plugin #168293

Sameri11 · 2025-05-04T15:52:40Z

More context in #153476 (comment) and #153476 (comment)

TLDR: abiFilters cannot be added to templates (the original issue proposes that) because it will break the Gradle build if the --splits-per-abi option is provided:

Conflicting configuration : 'armeabi-v7a,arm64-v8a,x86_64' in ndk abiFilters cannot be present when splits abi filters are set : armeabi-v7a,arm64-v8a

In this PR, abiFilters is added programmatically in the Flutter Gradle Plugin when the splits-per-abi option is not provided and only for non-debuggable builds.

As stated in #153476 (comment), abiFilters are actually useful in cases when a third-party dependency is used with the x86 variant. In other cases (such as a fresh Flutter app project), abiFilters are a bit excessive, but they do no harm.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall

LGTM, great find in #153476 (comment)!

I had suspected that abifilters were not necessary for the same reason you mentioned (that the FGP only packages the 3 ABIs it works on by default), but had not considered that the inclusion of a different native library could cause an x86 variant to get included.

packages/flutter_tools/test/integration.shard/gradle_jni_packaging_test.dart

gmackall · 2025-05-20T20:03:52Z

Google testing seems to just not work w/ changes to the FGP, I'll override the failure.

reidbaker

Thank you so much for this pr! This is a tricky issue and I like the root cause work you did.

packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt

reidbaker · 2025-05-28T19:31:50Z

packages/flutter_tools/gradle/src/main/kotlin/FlutterPlugin.kt

            }
+        } else {
+            FlutterPluginUtils.getAndroidExtension(project).buildTypes.forEach { buildType ->
+                if (!buildType.isDebuggable) {


I think this would run for flutter add to app projects. In add to app we have allow developers to possibly ship flutter on architectures that flutter does not support because they can control when flutter is run.

Please modify this if statement to only run if the project is a normal full flutter app.
I think that could be done by using FlutterPluginUtils.isFlutterAppProject. (and a test)

Wow, it's gonna take couple days for me to refresh knowledge about a2a and figure out test strategy. But I think just FlutterPluginUtils.isFlutterAppProject is not sufficient here because it just checks AGP's app extension exists, and in this case a2a project where flutter module added as source code dependency still might be affected.
Anyway, I'll figure out something, will keep you posted :)

Or maybe I'm wrong thinking that FGP applied to a2a project with sources dependency 🤔 Anyway, as I said, I'm going to need some time.

@reidbaker Hi again!
I played a little with add-to-app and here what I found:

For flutter build aar, abiFilters does nothing, because liblfutter.so is not packaged to aar artefacts, they only being added as dependencies to pom files. So change from this PR does not affect this case.

When flutter module added as a project dependency (implementation(project(":flutter"))), FGP is not applied to the main app subproject, so apply is not called at all – this case is also not affected by this PR.

I mean, adding this condition might be semantically justified, say, we want emphasize that only app-building case affected. But in that case it might be hard to test this, because there won't be case where abiFilters is actually affects packaging.

So, I do not see any case where this change might affect a-2-a scenario. Only question is, what do I miss here? :)

Thank you for that research. Can you add a comment that helps explain that logic here?

Indeed :) I've added a comment. Let me know if it's too excessive. And thanks for review!

reidbaker

Approve % comment explaining what the code being added does in plain english and why it does not impact add to app.

…flutter#168293)

fixes flutter#153476 More context in flutter#153476 (comment) and flutter#153476 (comment) TLDR: `abiFilters` cannot be added to templates (the original issue proposes that) because it will break the Gradle build if the `--splits-per-abi` option is provided: ``` Conflicting configuration : 'armeabi-v7a,arm64-v8a,x86_64' in ndk abiFilters cannot be present when splits abi filters are set : armeabi-v7a,arm64-v8a ``` In this PR, `abiFilters` is added programmatically in the Flutter Gradle Plugin when the `splits-per-abi` option is not provided and only for non-debuggable builds. As stated in flutter#153476 (comment), `abiFilters` are actually useful in cases when a third-party dependency is used with the `x86` variant. In other cases (such as a fresh Flutter app project), `abiFilters` are a bit excessive, but they do no harm.  ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…flutter#168293)

_Description of what this PR is changing or adding, and why:_ Adds a breaking change for flutter/flutter#168293 which landed in 3.35. TLDR: To set custom Android ABI filters, you must clear the defaults that Flutter sets or use the Flutter-provided flag for doing so. _Issues fixed by this PR (if any):_ Fixes flutter/flutter#174004 _PRs or commits this PR depends on (if any):_ N/A ## Presubmit checklist - [ ] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [ ] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour <[email protected]> Co-authored-by: Gray Mackall <[email protected]>

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 4, 2025

Sameri11 force-pushed the android-ndk-abi-filters branch from 339f273 to 3645c87 Compare May 11, 2025 16:15

github-actions bot added the platform-android Android applications specifically label May 11, 2025

Sameri11 force-pushed the android-ndk-abi-filters branch 3 times, most recently from 0a18e48 to eaae72e Compare May 14, 2025 06:00

Sameri11 changed the title ~~[Android] add abiFilters to app templates~~ [Android] add abiFilters to Flutter Gradle Plugin May 15, 2025

Sameri11 force-pushed the android-ndk-abi-filters branch 3 times, most recently from 9525cba to 4d80540 Compare May 16, 2025 06:07

Sameri11 marked this pull request as ready for review May 16, 2025 08:50

reidbaker requested review from reidbaker, gmackall and mboetger May 19, 2025 18:05

gmackall approved these changes May 19, 2025

View reviewed changes

packages/flutter_tools/test/integration.shard/gradle_jni_packaging_test.dart Outdated Show resolved Hide resolved

packages/flutter_tools/test/integration.shard/gradle_jni_packaging_test.dart Show resolved Hide resolved

Sameri11 force-pushed the android-ndk-abi-filters branch 2 times, most recently from 00b8ab6 to 2e82307 Compare May 20, 2025 18:27

Dooks123 mentioned this pull request May 28, 2025

Investigate path resolution for "libflutter.so" binary #151638

Open

reidbaker reviewed May 28, 2025

View reviewed changes

Sameri11 force-pushed the android-ndk-abi-filters branch 2 times, most recently from 6c08273 to 6589fc8 Compare June 5, 2025 18:11

Sameri11 requested a review from reidbaker June 5, 2025 18:12

Sameri11 force-pushed the android-ndk-abi-filters branch from 6589fc8 to c00fe39 Compare June 5, 2025 18:31

reidbaker approved these changes Jun 10, 2025

View reviewed changes

Sameri11 force-pushed the android-ndk-abi-filters branch 3 times, most recently from 3a32030 to 6a95b50 Compare June 14, 2025 12:51

Sameri11 added 2 commits June 15, 2025 16:10

add adiFilters to FlutterGradlePlugin

363a850

use DEFAULT platforms and mapping instead hardcoded list of archs

51a2655

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

92a7bd7

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 17, 2025

Roll Flutter from 8303a96a0a99 to e496ad5ea754 (54 revisions) flutter/packages#9443

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

69300b9

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to b6d2b3552bc2 (65 revisions) flutter/packages#9446

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

f32352d

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to 6056b553990f (66 revisions) flutter/packages#9447

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

4e6e1ef

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to 75a77fec8c1b (67 revisions) flutter/packages#9448

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

38c7f60

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to fac358d6fe65 (68 revisions) flutter/packages#9449

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

2a9331e

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to 9bfb92e6f89b (69 revisions) flutter/packages#9450

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

2377bc2

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to 25931666f36c (70 revisions) flutter/packages#9451

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

51c2574

…flutter#168293)

engine-flutter-autoroll mentioned this pull request Jun 18, 2025

Roll Flutter from 8303a96a0a99 to 784e5149aa8c (71 revisions) flutter/packages#9452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

f88717e

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

384d0d9

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

efe0187

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

8baa418

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

05cb0ce

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

d83d9cd

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

b92b7a6

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

23c83f6

…flutter#168293)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

1c8ce957e [Android] add abiFilters to Flutter Gradle Plugin (flutter/…

3472c80

…flutter#168293)

camsim99 mentioned this pull request Aug 22, 2025

[Android] Add breaking changes page on default ABI filters flutter/website#12350

Merged

4 tasks

tirth-patel-nc mentioned this pull request Sep 24, 2025

[Android] reconfigure abiFilters not effect in productFlavors abiFilters #175845

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android] add abiFilters to Flutter Gradle Plugin #168293

[Android] add abiFilters to Flutter Gradle Plugin #168293

Uh oh!

Sameri11 commented May 4, 2025 •

edited

Loading

Uh oh!

gmackall left a comment

Uh oh!

Uh oh!

Uh oh!

gmackall commented May 20, 2025

Uh oh!

reidbaker left a comment

Uh oh!

Uh oh!

reidbaker May 28, 2025

Uh oh!

Sameri11 Jun 1, 2025 •

edited

Loading

Uh oh!

Sameri11 Jun 1, 2025

Uh oh!

Sameri11 Jun 5, 2025

Uh oh!

reidbaker Jun 10, 2025

Uh oh!

Sameri11 Jun 12, 2025

Uh oh!

reidbaker left a comment

Uh oh!

Uh oh!

[Android] add abiFilters to Flutter Gradle Plugin #168293

[Android] add abiFilters to Flutter Gradle Plugin #168293

Uh oh!

Conversation

Sameri11 commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gmackall commented May 20, 2025

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

reidbaker May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Sameri11 Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sameri11 Jun 1, 2025

Choose a reason for hiding this comment

Uh oh!

Sameri11 Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Sameri11 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sameri11 commented May 4, 2025 •

edited

Loading

Sameri11 Jun 1, 2025 •

edited

Loading