Fix Chip delete button semantic bounds #168310

bleroux · 2025-05-05T13:56:12Z

Description

This PR fixes Chip's delete icon semantic tap target.
Chip implementation extends the hit area of the delete icon but it did not expand the semantic bounds.

Before

After

Related Issue

Fixes Chip delete button tap target does not meet platform recommended tap target size

Tests

Adds 1 test.

Piinks · 2025-05-05T21:36:00Z

packages/flutter/lib/src/material/chip.dart

+    width: kMinInteractiveDimension,
+    height: kMinInteractiveDimension,


It is not always this though, based on the MaterialTapTargetSize and VisualDensity, it could be a different rect correct?

I hesitated on this because it is not clear from the Material spec that the tap target size should change based on visual density.
But you're right: it is preferable to follow what is done in most of the Flutter Material widget.

I updated he PR, using the same logic than several Flutter widgets (radio, checkbox). Which means tap target size defaults to:

48x48 on mobile

32x32 on desktop

For reference, see

flutter/packages/flutter/lib/src/material/checkbox.dart

Lines 519 to 529 in c02d22d

Size size = switch (effectiveMaterialTapTargetSize) {

MaterialTapTargetSize.padded => const Size(

kMinInteractiveDimension,

kMinInteractiveDimension,

),

MaterialTapTargetSize.shrinkWrap => const Size(

kMinInteractiveDimension - 8.0,

kMinInteractiveDimension - 8.0,

),

};

size += effectiveVisualDensity.baseSizeAdjustment;

I am also a bit torn at this, according to material guide there are no exception. and the WCAG has lower limit of 44px. the only guideline that allows for a smaller sizes are google internal guideline (only googler can see, tldr: for web/desktop, prefer 48 pixel but must > 24 pixel), but I think we should just go with 48px so that we don't get into trouble when fulfilling public guideline.

I think the logic of smaller size in different mode originate from
https://github.com/flutter/flutter/pull/18369/files. cc @jonahwilliams , Do you have any insight on how the smaller size are picked?

actually nvm, there is a clause in WCAG as well
https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum
and the lower bound is also 24. we should be fine here

Thanks for sharing these links. Especially because several existing Flutter widgets use a similar logic (reducing the lower bounds on destop to 32x32), it is good to know that we are fine.

chunhtai · 2025-05-05T21:37:13Z

packages/flutter/lib/src/material/chip.dart

+  @override
+  Rect get semanticBounds => Rect.fromCenter(
+    center: paintBounds.center,
+    width: kMinInteractiveDimension,


what if the paint size is larger than kMinInteractiveDimension already? maybe this should be a math.min between the actual size and the interactive size?

Good point, thanks. 🙏
Do you mean math.max instead of math.min? (using the paint size when it is larger than kMinInteractiveDimension).

Piinks · 2025-05-06T20:17:55Z

packages/flutter/lib/src/material/chip.dart

-    return Semantics(
-      container: true,
-      button: true,
+


Just after we actually call _buildDeleteIcon, some similar logic is used. we should ensure the semantic size is consistent, since it is also used for custom hit testing. This is why the hit test area is ok with the right tap target size and visual density, but the semantic bounds did not reflect that.
The constraints that are similarly computed are down near the use of _ChipRedirectingHitDetectionWidget. Maybe we can consolidate the similar logic to compute before we call _buildDeleteIcon, and just pass the size to the method?

I looked more closely at the current hit area logic and at the M3 Chip specification (this is the first time I work on the Chip widget 😅 ).

From the specification (see https://m3.material.io/components/chips/specs#1dcff1cb-22f5-41da-809e-6c85b467cff1):

And in the table below the diagram:

From the current Chip implementation:

the default height of the hit target area is correct: 48dp on mobile (the visual height of the Chip is 32 which is compliant and the total height is expanded to 48 due to _ChipRedirectingHitDetectionWidget).

the default width of the hit target area is not correct: 36dp on mobile. It seems the motivation for that was to avoid that the tap area of the delete icon overflows over the label area.

If we don't want a fix where the hit target area and the semantic area are not exactly the same (this PR), it means that the current Chip implementation should be fixed by:

extending the default hit area to overflows over the label

extending the default hit area to overflows out of the Chip right border. This seems to be expected from the M3 spec because the center of the delete icon is at 17 pixels from the Chip right border (iconWidth / 2 + iconRightPadding = 18/2 + 8). So the hit area should overflows by 7 pixels outside of the Chip border to comply with the 48x48 tap area.

I can work on this. I expect the second change (extending the hit area outside the Chip border) to break several existing tests and Google tests (as that the default chip width on mobile will be larger than now).

Ah ok! Thank you for explaining and digging in to this!

Piinks · 2025-05-06T20:20:15Z

packages/flutter/test/material/chip_test.dart

@@ -6167,6 +6167,96 @@ void main() {
      SystemMouseCursors.forbidden,
    );
  });
+


To ensure the custom hit test and the semantic bounds match up and we haven't regressed anything, can you add a test where the delete button is larger than 48x48 - if that is possible? I am less familiar with this widget, and it is surprisingly complex. :)

I will try, but I'm not confident for the moment that we can get the hit test and semantics bounds always matching (the calculation for the hit logic area is complex. Looking at the history, It looks like Greg tried hard to get a logic that fits most of the use cases and that it was not an easy task). Let me experiment and share my findings.

'Delete button semantic tap target can be larger than the minimum interactive dimension' - if that is possible?

Yes, it is possible, for instance by increasing the label font size and the icon size (I did it in one of the test I added in the second commit for this PR). I will also try to see the effect of increasing text scaling.

chunhtai · 2025-05-06T23:07:23Z

packages/flutter/lib/src/material/chip.dart

@@ -2425,6 +2433,55 @@ bool _hitIsOnDeleteIcon({
  };
 }

+class _DeleteButtonSemantic extends SingleChildRenderObjectWidget {


nit: should probably name something like ensureMinSemanticsSize

_EnsureMinSemanticsSize*

Maybe we should consider (separately) if this would be a useful wrapper widget in the core framework.

Maybe we should consider (separately) if this would be a useful wrapper widget in the core framework.

Interesting discussion!

A wrapper widget which manages the interactive minimum size for both hit testing and Semantics (to get them correct and in sync) might be useful.
It somewhat already exists as a private class named _InputPadding which is duplicated in button_style_button.dart and toggle_buttons.dart.

About _EnsureMinSemanticSize, I'm not sure it is something we want to promote because it does not ensure that the Semantics area bounds are in synch with the hit area bounds. It is useful in the Chip context because it would be a breaking change to modify now the hit area bounds (as it will require to add padding on the left side of every InputChip with a delete icon, and then maybe to all chips because otherwise developers would have to compensate for this padding specifically for some chips and not for others).

Piinks

LGTM with the nit from @chunhtai regarding the name. Thank you!

Piinks · 2025-05-15T22:35:54Z

packages/flutter/lib/src/material/chip.dart

-    return Semantics(
-      container: true,
-      button: true,
+


Ah ok! Thank you for explaining and digging in to this!

…e larger than kMinInteractiveDimension

Piinks · 2025-05-16T19:53:45Z

Updated the google test to passing, it was a screenshot of semantic bounds. :)

auto-submit · 2025-05-16T19:57:20Z

auto label is removed for flutter/flutter/168310, Failed to enqueue flutter/flutter/168310 with HTTP 400: GraphQL mutate failed.

chunhtai

LGTM, except one minor optimization

packages/flutter/lib/src/material/chip.dart

Co-authored-by: chunhtai <[email protected]>

Piinks · 2025-05-16T20:54:37Z

Thanks @chunhtai! Committed.

auto-submit · 2025-05-16T22:31:14Z

autosubmit label was removed for flutter/flutter/168310, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

)

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181) 2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

…r#9305) Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/flutter@9a78af5...33cdd8e 2025-05-21 [email protected] Feat: Add persistentFooterDecoration for scaffold (flutter/flutter#167524) 2025-05-21 [email protected] Removed repeated entry in `CHANGELOG.md` (flutter/flutter#165273) 2025-05-21 [email protected] [native assets] Graduate to preview (flutter/flutter#169194) 2025-05-21 [email protected] [Impeller] disable gl ext render to texture on vivante. (flutter/flutter#169153) 2025-05-21 [email protected] fix(widget_inspector): add null check for flex factor property to prevent exception (flutter/flutter#167890) 2025-05-21 [email protected] Unpin leak_tracker. (flutter/flutter#169079) 2025-05-21 [email protected] runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (flutter/flutter#168952) 2025-05-21 [email protected] Remove `isExplicitPackageDependenciesEnabled: true`, it is the default. (flutter/flutter#169156) 2025-05-21 [email protected] Roll pub packages (flutter/flutter#169181) 2025-05-20 [email protected] Fix the issue with Tooltip (flutter/flutter#168546) 2025-05-20 [email protected] [native assets] Roll dependencies (flutter/flutter#169073) 2025-05-20 [email protected] Add documentation for experimental branches, update artifacts. (flutter/flutter#169109) 2025-05-20 [email protected] [flutter_tool] Remove unused environment flags in JS compiler (flutter/flutter#169097) 2025-05-20 [email protected] Add support for hiding widget subtrees from the widget inspector (flutter/flutter#169007) 2025-05-20 [email protected] Roll Fuchsia GN SDK from jsZSHIOmQAs3URvWU... to _tkqOQZ2qB5CxDe57... (flutter/flutter#169113) 2025-05-20 [email protected] Skip running `Linux fuchsia_test` on non-master channel. (flutter/flutter#169106) 2025-05-19 [email protected] Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (flutter/flutter#169099) 2025-05-19 [email protected] Shared element transition for predictive back (flutter/flutter#154718) 2025-05-19 [email protected] Fix DDC library bundle format test files to correctly pass flags (flutter/flutter#169095) 2025-05-19 [email protected] Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (flutter/flutter#169031) 2025-05-19 [email protected] Fix keyboard_hot_restart_ios flakes (flutter/flutter#168518) 2025-05-19 [email protected] fix android studio lint about lambda argument (flutter/flutter#168901) 2025-05-19 [email protected] Fix typo in gpu_surface_gl_impeller.cc (flutter/flutter#168395) 2025-05-19 [email protected] Modernize system executable detection across components (flutter/flutter#169018) 2025-05-19 [email protected] Update documentation for `Size` and `Rect` classes (flutter/flutter#168031) 2025-05-19 [email protected] Update the `RangeSlider` widget to the 2024 Material Design appearance (flutter/flutter#163736) 2025-05-19 [email protected] Roll Packages from 58d4016 to af0b9a9 (5 revisions) (flutter/flutter#169075) 2025-05-19 [email protected] Only bundle assets and plugins from transitive closure of dependencies (flutter/flutter#160443) 2025-05-19 [email protected] Make FlutterGeneratedPluginSwiftPackage an Xcode root package (flutter/flutter#168789) 2025-05-19 [email protected] docs: Update deprecation message for Slider.year2023 (flutter/flutter#169053) 2025-05-18 [email protected] macOS: port ResizeSynchronizer to Swift (flutter/flutter#168959) 2025-05-17 [email protected] Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (flutter/flutter#169024) 2025-05-17 [email protected] [tool] Remove unused `reportNullSafety` getter (flutter/flutter#168484) 2025-05-17 [email protected] Add flag to skip bundling extension safe builds in frameworks for DDM (flutter/flutter#168955) 2025-05-16 [email protected] Fixes Navigator calls onPopInvokedWithResult when onPopPage return false (flutter/flutter#168567) 2025-05-16 [email protected] [hcpp/hc] Fix talkback for HC and HCPP Android platform views (flutter/flutter#168939) 2025-05-16 [email protected] [Impeller] separate immutable sampler descriptors. (flutter/flutter#169011) 2025-05-16 [email protected] TextField magnifier stuck on long press cancel (flutter/flutter#167881) 2025-05-16 [email protected] Fix Chip delete button semantic bounds (flutter/flutter#168310) 2025-05-16 [email protected] Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (flutter/flutter#169009) 2025-05-16 [email protected] [ Widget Preview ] Refactor `@Preview()` detection and code generation (flutter/flutter#168307) 2025-05-16 [email protected] Roll Packages from 2dff621 to 58d4016 (2 revisions) (flutter/flutter#168999) 2025-05-16 [email protected] Remove `unittests` from `windows_host_engine` GN targets. (flutter/flutter#168991) 2025-05-16 [email protected] Fix bug with debugging support code not getting injected on edge devices (flutter/flutter#168073) 2025-05-16 [email protected] Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (flutter/flutter#168989) 2025-05-16 [email protected] Resolve Cupertino textstyle in MaterialBasedCupertinoThemeData (flutter/flutter#167597) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 5, 2025

bleroux requested review from Piinks and chunhtai May 5, 2025 15:58

Piinks reviewed May 5, 2025

View reviewed changes

chunhtai reviewed May 5, 2025

View reviewed changes

bleroux force-pushed the Fix_Chip_delete_button_semantic_bounds branch from bf68169 to 80e1fd6 Compare May 6, 2025 08:15

bleroux requested review from chunhtai and Piinks May 6, 2025 18:37

Piinks reviewed May 6, 2025

View reviewed changes

chunhtai reviewed May 6, 2025

View reviewed changes

Piinks approved these changes May 15, 2025

View reviewed changes

bleroux added 3 commits May 16, 2025 14:33

Fix Chip delete button semantic bounds

6438876

Adjust semantic bounds based on visualDensity + semantic bounds can v…

62497e5

…e larger than kMinInteractiveDimension

Rename _DeleteButtonSemantic to _EnsureMinSemanticsSize

6903ebe

bleroux force-pushed the Fix_Chip_delete_button_semantic_bounds branch from 80e1fd6 to 6903ebe Compare May 16, 2025 12:57

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

chunhtai approved these changes May 16, 2025

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated Show resolved Hide resolved

Update packages/flutter/lib/src/material/chip.dart

78e726d

Co-authored-by: chunhtai <[email protected]>

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2025

auto-submit bot added this pull request to the merge queue May 16, 2025

Merged via the queue into flutter:master with commit 358e2f0 May 16, 2025
77 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

ac9d2a3

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 63f9060fb030 (32 revisions) flutter/packages#9286

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

13c343b

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to b23840d04447 (33 revisions) flutter/packages#9288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

ad84fb6

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 25692db52876 (34 revisions) flutter/packages#9289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

fbf5c52

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 559c314ba3fd (35 revisions) flutter/packages#9290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

2ee41d9

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 5bcde8fa7b82 (36 revisions) flutter/packages#9291

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

7a34a23

)

engine-flutter-autoroll mentioned this pull request May 19, 2025

Roll Flutter from 9a78af5eb067 to 80f5de5da95d (38 revisions) flutter/packages#9292

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

576d489

)

engine-flutter-autoroll mentioned this pull request May 20, 2025

Roll Flutter from 9a78af5eb067 to c04cd2b18ebf (46 revisions) flutter/packages#9294

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

154da3f

)

engine-flutter-autoroll mentioned this pull request May 20, 2025

Roll Flutter from 9a78af5eb067 to c04cd2b18ebf (46 revisions) flutter/packages#9296

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

c9ce413

)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 61fe9b6b67c0 (55 revisions) flutter/packages#9299

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

db25cca

)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

a6652cf

)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to dd671fae53d3 (56 revisions) flutter/packages#9301

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

8221eee

)

This was referenced May 21, 2025

Roll Flutter from 9a78af5eb067 to 534b250a562c (58 revisions) flutter/packages#9303

Closed

Roll Flutter from 9a78af5eb067 to f7354da75b27 (59 revisions) flutter/packages#9304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

5ffa1ad

)

engine-flutter-autoroll mentioned this pull request May 21, 2025

Roll Flutter from 9a78af5eb067 to 33cdd8ef31dc (60 revisions) flutter/packages#9305

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

358e2f003 Fix Chip delete button semantic bounds (flutter/flutter#168310

2ab20ae

)

		width: kMinInteractiveDimension,
		height: kMinInteractiveDimension,

	Size size = switch (effectiveMaterialTapTargetSize) {
	MaterialTapTargetSize.padded => const Size(
	kMinInteractiveDimension,
	kMinInteractiveDimension,
	),
	MaterialTapTargetSize.shrinkWrap => const Size(
	kMinInteractiveDimension - 8.0,
	kMinInteractiveDimension - 8.0,
	),
	};
	size += effectiveVisualDensity.baseSizeAdjustment;

Fix Chip delete button semantic bounds #168310

Fix Chip delete button semantic bounds #168310

Uh oh!

Conversation

bleroux commented May 5, 2025

Description

Before

After

Related Issue

Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bleroux May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bleroux May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks commented May 16, 2025

Uh oh!

auto-submit bot commented May 16, 2025

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Piinks commented May 16, 2025

Uh oh!

auto-submit bot commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

chunhtai May 6, 2025 •

edited

Loading

bleroux May 9, 2025 •

edited

Loading

bleroux May 16, 2025 •

edited

Loading