Thanks to visit codestin.com
Credit goes to github.com

Skip to content

iOS/macOS: Consistent Flutter copyright headers #168390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 6, 2025

A long time ago, back after the fork from Chromium, we updated all Chromium BSD copyright notices to Flutter. We did this in the engine, but not in the buildroot. After the monorepo merge, we've now got a mix. This corrects Chromium copyright notices for iOS/macOS files only, and adds a missing copyright header.

No test changes since this touches only comments, and introduces no functional changes.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

A long time ago, back after the fork from Chromium, we updated all
Chromium BSD copyright notices to Flutter. We did this in the engine,
but not in the buildroot. After the monorepo merge, we've now got a mix.
This corrects Chromium copyright notices for iOS/macOS files only, and
adds a missing copyright header.
@cbracken cbracken requested a review from vashworth as a code owner May 6, 2025 17:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. a: desktop Running on desktop f: integration_test The flutter/packages/integration_test plugin platform-macos labels May 6, 2025
@cbracken cbracken requested a review from a team May 6, 2025 17:26
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love pressing approve

@stuartmorgan-g
Copy link
Contributor

test-exempt: comments and informational metadata only

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
Copy link
Contributor

auto-submit bot commented May 6, 2025

autosubmit label was removed for flutter/flutter/168390, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman
Copy link
Member

jmagman commented May 6, 2025

Filed #168398 to include these files during the license analyzer step.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
Copy link
Contributor

auto-submit bot commented May 6, 2025

autosubmit label was removed for flutter/flutter/168390, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 7, 2025
Merged via the queue into flutter:master with commit e89c392 May 7, 2025
181 of 182 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@cbracken cbracken deleted the missing-copyright-header branch May 7, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop a: tests "flutter test", flutter_test, or one of our tests engine flutter/engine repository. See also e: labels. f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants