-
Notifications
You must be signed in to change notification settings - Fork 28.5k
iOS/macOS: Consistent Flutter copyright headers #168390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A long time ago, back after the fork from Chromium, we updated all Chromium BSD copyright notices to Flutter. We did this in the engine, but not in the buildroot. After the monorepo merge, we've now got a mix. This corrects Chromium copyright notices for iOS/macOS files only, and adds a missing copyright header.
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love pressing approve
test-exempt: comments and informational metadata only |
autosubmit label was removed for flutter/flutter/168390, because - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Filed #168398 to include these files during the license analyzer step. |
autosubmit label was removed for flutter/flutter/168390, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
A long time ago, back after the fork from Chromium, we updated all Chromium BSD copyright notices to Flutter. We did this in the engine, but not in the buildroot. After the monorepo merge, we've now got a mix. This corrects Chromium copyright notices for iOS/macOS files only, and adds a missing copyright header.
No test changes since this touches only comments, and introduces no functional changes.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.