Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make MergeSemantics be able to merge customAction #168414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make MergeSemantics be able to merge customAction #168414

wants to merge 2 commits into from
+42 −1

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented May 6, 2025 •
edited
Loading

Fixes #166588

When merging semantics, an empty customSemanticsActions was always used instead of using the _customSemanticsActions of the current semantics node.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels May 6, 2025
@QuncCccccc QuncCccccc requested a review from chunhtai May 6, 2025 20:47
chunhtai
chunhtai reviewed May 6, 2025
View reviewed changes
packages/flutter/test/widgets/semantics_test.dart
MergeSemantics(
child: Column(
children: <Widget>[
Semantics(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To properly test this , they have to create their own node, so I think we need container:true for both semantics widget

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks! Just updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeSemantics does not merge custom actions
2 participants
@QuncCccccc @chunhtai