Thanks to visit codestin.com
Credit goes to github.com

Skip to content

macOS: trailing closures for FlutterRunLoop.perform* #168415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented May 6, 2025

Support trailing closure syntax in FlutterRunLoop perform methods. This
allows us to write Swift code like:

FlutterRunLoop.mainLoop.perform(withDelay: delay) {
  // code.
}

This also matches the ordering used in NSRunLoop/RunLoop:

Follow-up to #168174.

No tests since this is just a method rename.

Issue: #144791

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Support trailing closure syntax in FlutterRunLoop perform methods. This
allows us to write Swift code like:

```
FlutterRunLoop.mainLoop.perform(withDelay: delay) {
  // code.
}
```

Follow-up to flutter#168174.

Issue: flutter#144791
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. a: desktop Running on desktop platform-macos labels May 6, 2025
@cbracken cbracken requested a review from hellohuanlin May 6, 2025 21:45
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 7, 2025
Merged via the queue into flutter:master with commit 4af869e May 7, 2025
179 of 180 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@cbracken cbracken deleted the trailing-closure branch May 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants