[Widget Inspector] Clean-up changes in PR #167677 #168488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
May 7, 2025
| @@ -29,7 +29,7 @@ import 'page.dart'; | |||
| import 'scaffold.dart' show ScaffoldMessenger, ScaffoldMessengerState; | |||
| import 'scrollbar.dart'; | |||
| import 'theme.dart'; | |||
| import 'theme_data.dart'; | |||
| import 'theme_data.dart' show MaterialTapTargetSize; | |||
There was a problem hiding this comment.
Although theme.dart exports ThemeData, it doesn't export the MaterialTapTargetSize (which is the reason for the added import to theme_data.dart)
There was a problem hiding this comment.
Ah, I see! Maybe it should then. I looked around and noticed it is used multiple times like this. Can you change theme.dart to also export MaterialTapTargetSize as well instead?
Piinks
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #167677
Addresses clean-up comments in cherry-pick: #168386