Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Stop writing package_config_subset#169125

Merged
sigurdm merged 3 commits into
flutter:masterfrom
sigurdm:remove_package_config_subset_hack
Jun 3, 2025
Merged

Stop writing package_config_subset#169125
sigurdm merged 3 commits into
flutter:masterfrom
sigurdm:remove_package_config_subset_hack

Conversation

@sigurdm
Copy link
Copy Markdown
Contributor

@sigurdm sigurdm commented May 20, 2025

Fixes #168764

As of dart-lang/pub#4549 pub no longer rewrites the package_config.json file when nothing changes. And it doesn't write a timestamp in it.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 20, 2025
@sigurdm sigurdm requested a review from matanlurey May 20, 2025 09:42
@sigurdm
Copy link
Copy Markdown
Contributor Author

sigurdm commented May 20, 2025

cc @dcharkes

@dcharkes
Copy link
Copy Markdown
Contributor

dcharkes commented May 20, 2025

fyi @bkonyi

@flutter-dashboard
Copy link
Copy Markdown

flutter-dashboard Bot commented May 20, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169125 at sha f852f6e

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label May 20, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2025
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented May 23, 2025

autosubmit label was removed for flutter/flutter/169125, because Pull request flutter/flutter/169125 is not in a mergeable state.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025
@sigurdm sigurdm added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented Jun 3, 2025

autosubmit label was removed for flutter/flutter/169125, because - The status or check suite Linux analyzer_benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.

@sigurdm sigurdm added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@sigurdm sigurdm added this pull request to the merge queue Jun 3, 2025
Merged via the queue into flutter:master with commit c2ec328 Jun 3, 2025
141 of 143 checks passed
@sigurdm sigurdm deleted the remove_package_config_subset_hack branch June 3, 2025 11:39
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
76710a0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
be69975
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
d344559
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
416017b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
341eed1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
2a821f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
3c00cf7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
2e8d887
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
19e5b6a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
dc4d3d4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
83a809a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
66be4ea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
f98b474
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
af1ba41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
12ea0f9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
ff67fc6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
41a0d67
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
a292d49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
cd2858c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
dfa9aa1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
1045a9d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
bc4558d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
dc9371e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
4f3511a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c2ec328 Stop writing package_config_subset (flutter/flutter#169125)
36dfe2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcharkes dcharkes dcharkes approved these changes

@bkonyi bkonyi bkonyi approved these changes

+1 more reviewer

@matanlurey matanlurey matanlurey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove package_config_subset workaround

4 participants

@sigurdm @dcharkes @matanlurey @bkonyi