-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Normalize AppBarTheme #169130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Normalize AppBarTheme #169130
Conversation
2465ff1
to
fdc4855
Compare
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this normalization! LGTM:)
a2f78a8
to
a6b93c2
Compare
Signed-off-by: huycozy <[email protected]>
Signed-off-by: huycozy <[email protected]>
Signed-off-by: huycozy <[email protected]>
… type for appBarTheme Signed-off-by: huycozy <[email protected]>
Signed-off-by: huycozy <[email protected]>
…arTheme Signed-off-by: huycozy <[email protected]>
6c6feff
to
f1112fa
Compare
Signed-off-by: huycozy <[email protected]>
eb70cb1
to
409ba3d
Compare
This PR is to make
AppBarTheme
conform to Flutter Material's conventions for component themes:AppBarThemeData
class which defines overrides for the defaults forAppBar
properties.AppBarThemeData? data
andWidget? child
. This is now the preferred way to configure aAppBarTheme
:These two properties are made nullable to not break existing apps which has customized
ThemeData.appBarTheme
.AppBarTheme
to be anInheritedWidget
subclass.AppBarTheme
toAppBarThemeData
.AppBarThemeData
and update the existingAppBarTheme
tests.AppBarThemeData
toObject?
inThemeData
class, to bypass g3 tests, following Normalize BottomAppBarTheme #168586 (comment).Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.