Stop using isExplicitPackageDeps* to guard Darwin devDependencies.#169310
Stop using isExplicitPackageDeps* to guard Darwin devDependencies.#169310matanlurey wants to merge 3 commits into
isExplicitPackageDeps* to guard Darwin devDependencies.#169310Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I think I want to change the way we handle this a bit. Can we close this PR in favor of #169395? |
Sure, works for me. I'm hoping to get rid of the flags this week so if for some reason it stalls out I might push you on this, but happy to wait for now. |
This PR removes the flag
isExplicitPackageDependenciesEnabledfrom guarding DarwindevDependenciesremoval.The flag was added opt-in 3.29 and opt-out 3.32 and is now being removed with the logic "always enabled":
explicit-package-dependencies. #169283Tests already assumed this flag was always on, which is why no tests changes are made in this PR.