Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add dynamic module loader to flutter wasm entrypoint script. #169313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biggs0125 merged 4 commits into from
May 29, 2025
Merged

Add dynamic module loader to flutter wasm entrypoint script. #169313

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97507af
Add dynamic module loader to flutter wasm entrypoint script.
natebiggs May 22, 2025
eb217df
Add entrypoint URI to wasm URI too.
natebiggs May 27, 2025
77f22b6
Merge branch 'master' into dyn-mod-runtime
natebiggs May 28, 2025
6a258c0
Merge branch 'master' into dyn-mod-runtime
biggs0125 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add entrypoint URI to wasm URI too.
  • Loading branch information
@natebiggs
natebiggs committed May 27, 2025
commit eb217df58e4951c29e11e938d07f1ac3e34c9772
2 changes: 1 addition & 1 deletion engine/src/flutter/lib/web_ui/flutter_js/src/entrypoint_loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export class FlutterEntrypointLoader {
const compiledDartApp = await compiledDartAppPromise;
const dartApp = await compiledDartApp.instantiate(await importsPromise, {
loadDynamicModule: async (wasmUri, mjsUri) => {
const wasmBytes = fetch(resolveUrlWithSegments(wasmUri));
const wasmBytes = fetch(resolveUrlWithSegments(entrypointBaseUrl, wasmUri));
let mjsRuntimeUri = resolveUrlWithSegments(entrypointBaseUrl, mjsUri);
Comment on lines +178 to +180
Copy link
Copy Markdown
Contributor

@mdebbar mdebbar May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some documentation about this that I can look at? I'm trying to understand why mjsUri is prefixed by entrypointBaseUrl but not wasmUri.

Copy link
Copy Markdown
Contributor Author

@biggs0125 biggs0125 May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out, thanks! During local testing this worked without that but the paths are probably simpler in that environment.

I went ahead and added the entrypointBaseUrl since the URL generated should have the same format as that of the main module which also uses entrypointBaseUrl.

Documentation on this input here: https://github.com/dart-lang/sdk/blob/main/pkg/dart2wasm/lib/js/runtime_blob.dart#L54

Copy link
Copy Markdown
Contributor

@mdebbar mdebbar May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay, that makes more sense :)

Thanks for the link!

if (this._ttPolicy != null) {
mjsRuntimeUri = this._ttPolicy.createScriptURL(mjsRuntimeUri);
Expand Down