fix[widget_inspector]: Widget Inspector Directionality & Move button tooltip.#169425
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
@Piinks |
|
Could you please review this? |
|
I am not qualified to review here. CC @elliette |
elliette
left a comment
There was a problem hiding this comment.
Thank you for this PR! And my apologies for missing the RTL directionality in the original implementation.
A few small changes but overall LGTM!
You're welcome :) Could you please check now |
elliette
left a comment
There was a problem hiding this comment.
A few more requests but this is looking good, thank you!
|
Could you check again now 💯 |
|
One more comment, then LGTM. |
Update comments Co-authored-by: Kenzie Davisson <[email protected]>
|
@kenzieschmoll |
Fix Widget Inspector buttons direction & arrow button tooltip text on when the App locale is RTL:
Before:
After:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.