Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Impeller] Maintain a global map of each context's currently active thread-local command pools #169548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
May 29, 2025
Merged

[Impeller] Maintain a global map of each context's currently active thread-local command pools #169548

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea1d604
[Impeller] Maintain a global map of each context's currently active t…
jason-simmons May 27, 2025
40cf7ff
insertion
jason-simmons May 28, 2025
330b65c
insertion2
jason-simmons May 28, 2025
d2ef653
context hash
jason-simmons May 28, 2025
150b28b
check command_pool_recycler in context dtor
jason-simmons May 28, 2025
2013bee
Dispose thread-local command pools during teardown of Impeller golden…
jason-simmons May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Dispose thread-local command pools during teardown of Impeller golden… 
… playground tests

On Vulkan the golden tests are using a single ContextVK instance that is shared
among all tests.  The ContextVK is never deleted by the test harness.

So when the test process exits there may still be a CommandPoolVK in the
thread-local map.  The map and the CommandPoolVK will then be destructed
when global and thread-local objects are destructed, which may be unsafe.

Calling DisposeThreadLocalCachedResources forces cleanup of the thread-local
map when each test case finishes.
  • Loading branch information
@jason-simmons
jason-simmons committed May 29, 2025
commit 2013bee9b2e6f791bb4495e671eb234c587e0ada
8 changes: 8 additions & 0 deletions engine/src/flutter/impeller/golden_tests/golden_playground_test_mac.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ void GoldenPlaygroundTest::SetTypographerContext(

void GoldenPlaygroundTest::TearDown() {
ASSERT_FALSE(dlopen("/usr/local/lib/libMoltenVK.dylib", RTLD_NOLOAD));

auto context = GetContext();
if (context) {
context->DisposeThreadLocalCachedResources();
}
}

namespace {
Expand Down Expand Up @@ -280,6 +285,9 @@ RuntimeStage::Map GoldenPlaygroundTest::OpenAssetAsRuntimeStage(
}

std::shared_ptr<Context> GoldenPlaygroundTest::GetContext() const {
if (!pimpl_->screenshotter) {
return nullptr;
}
return pimpl_->screenshotter->GetPlayground().GetContext();
}

Expand Down