Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Use consist slashes when generating dep files #169570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 6 commits into from
May 28, 2025
Merged

🐛 Use consist slashes when generating dep files #169570

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0951fac
🐛 Use consist slashes when generating dep files
AlexV525 May 28, 2025
1cc4a01
🐛 --
AlexV525 May 28, 2025
9a7e8d4
🐛 ++
AlexV525 May 28, 2025
2cbbd78
🐛 Normalize the path before creating a file object
AlexV525 May 28, 2025
01314dd
🧪 Add test and improve previous
AlexV525 May 28, 2025
25dc0b5
✅ ++
AlexV525 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
✅ ++
  • Loading branch information
@AlexV525
AlexV525 committed May 28, 2025
commit 25dc0b56da7f695e96a257085e20effc01a217b5
19 changes: 13 additions & 6 deletions packages/flutter_tools/test/general.shard/build_system/depfile_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ void main() {
fileSystem = MemoryFileSystem.test();
depfileService = DepfileService(logger: BufferLogger.test(), fileSystem: fileSystem);
});

testWithoutContext('Can parse depfile from file', () {
final File depfileSource = fileSystem.file('example.d')..writeAsStringSync('''
a.txt: b.txt
Expand Down Expand Up @@ -48,28 +49,34 @@ a.txt c.txt d.txt: b.txt
});

testWithoutContext('Can parse depfile with windows file paths', () {
fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
depfileService = DepfileService(logger: BufferLogger.test(), fileSystem: fileSystem);
final FileSystem fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
final DepfileService depfileService = DepfileService(
logger: BufferLogger.test(),
fileSystem: fileSystem,
);
final File depfileSource = fileSystem.file('example.d')..writeAsStringSync(r'''
C:\\a1.txt C:\\a2/a3.txt: C:\\b1.txt C:\\b2/b3.txt
''');
final Depfile depfile = depfileService.parse(depfileSource);

expect(depfile.inputs.map((File e) => e.path).toList(), <String>[
r'C:\b1.txt',
r'C:\b2/b3.txt',
r'C:\b2\b3.txt',
]);
expect(depfile.outputs.map((File e) => e.path).toList(), <String>[
r'C:\a1.txt',
r'C:\a2/a3.txt',
r'C:\a2\a3.txt',
]);
});

testWithoutContext(
'Can escape depfile with windows file paths and spaces in directory names',
() {
fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
depfileService = DepfileService(logger: BufferLogger.test(), fileSystem: fileSystem);
final FileSystem fileSystem = MemoryFileSystem.test(style: FileSystemStyle.windows);
final DepfileService depfileService = DepfileService(
logger: BufferLogger.test(),
fileSystem: fileSystem,
);
final File inputFile =
fileSystem.directory(r'Hello Flutter').childFile('a.txt').absolute
..createSync(recursive: true);
Expand Down