Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tests] Increase linux timeout and skip on others #169627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
May 29, 2025
Merged

[tests] Increase linux timeout and skip on others #169627

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44213db
[tests] Increase linux timeout and skip on others
nshahan May 28, 2025
04e8892
add issue links
nshahan May 28, 2025
25da533
align test timeout seconds and remove another skip
nshahan May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2246,7 +2246,7 @@ targets:

- name: Linux web_tool_tests
recipe: flutter/flutter_drone
timeout: 60
timeout: 90 # https://github.com/flutter/flutter/issues/169634
Comment thread
nshahan marked this conversation as resolved.
properties:
dependencies: >-
[
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
@Tags(<String>['flutter-test-driver'])
@Skip('https://github.com/flutter/flutter/issues/169304')
Comment thread
nshahan marked this conversation as resolved.
library;

import '../src/common.dart';
Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
Copy link
Copy Markdown
Contributor

@mdebbar mdebbar May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file, and the ones below, have been running on all platforms for a while and not causing timeouts. Should we keep them that way if there's value in running them on different platforms?

Copy link
Copy Markdown
Contributor Author

@nshahan nshahan May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to run more tests on all platforms but my understanding from the discussion on #169304 was that the timeouts were increased for the mac and windows configurations and they also have the least amount of resources available. To find a middle ground during this period where we have two separate modes to test I thought we could avoid running tests of the non-default settings on all platforms.

@Tags(<String>['flutter-test-driver'])
library;

Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/hot_reload_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
@Tags(<String>['flutter-test-driver'])
library;

Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
@Tags(<String>['flutter-test-driver'])
library;

Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
@Tags(<String>['flutter-test-driver'])
library;

Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
@Tags(<String>['flutter-test-driver'])
library;

Expand Down