Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] Pass the same optimization level to both stages of JS compiler #169642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
May 29, 2025
Merged

[web] Pass the same optimization level to both stages of JS compiler #169642

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8790561
[web] Pass the same optimization level to both stages of JS compiler
kevmoo May 29, 2025
42ecb86
Merge branch 'master' into i134423_same_flags_js
kevmoo May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[web] Pass the same optimization level to both stages of JS compiler 
Ensures that late variables names are cleaned up

Fixes #134423
  • Loading branch information
@kevmoo
kevmoo committed May 29, 2025
commit 879056190183c09756dbd029604736a47d621dea
2 changes: 1 addition & 1 deletion packages/flutter_tools/lib/src/web/compiler_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ class JsCompilerConfig extends WebCompilerConfig {
if (nativeNullAssertions) '--native-null-assertions',
if (!sourceMaps) '--no-source-maps',
if (buildMode == BuildMode.debug) '--enable-asserts',
'-O${optimizationLevelForBuildMode(buildMode)}',
];

@override
Expand All @@ -115,7 +116,6 @@ class JsCompilerConfig extends WebCompilerConfig {
List<String> toCommandOptions(BuildMode buildMode) => <String>[
if (minify ?? buildMode == BuildMode.release) '--minify' else '--no-minify',
...toSharedCommandOptions(buildMode),
'-O${optimizationLevelForBuildMode(buildMode)}',
if (dumpInfo) '--stage=dump-info-all',
if (noFrequencyBasedMinification) '--no-frequency-based-minification',
if (csp) '--csp',
Expand Down
15 changes: 15 additions & 0 deletions packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -566,6 +567,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKIA=true',
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -609,6 +611,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -654,6 +657,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -698,6 +702,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -741,6 +746,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -785,6 +791,7 @@ name: foo
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--native-null-assertions',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -831,6 +838,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O3',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -876,6 +884,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -936,6 +945,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -981,6 +991,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKIA=true',
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -1026,6 +1037,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -1074,6 +1086,7 @@ name: foo
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'--enable-asserts',
'-O1',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -1119,6 +1132,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down Expand Up @@ -1165,6 +1179,7 @@ name: foo
'-DFLUTTER_WEB_USE_SKWASM=false',
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
'--no-source-maps',
'-O4',
'-o',
environment.buildDir.childFile('app.dill').absolute.path,
'--packages=/.dart_tool/package_config.json',
Expand Down
Loading