[Impeller] Use StrokePathSourceGeometry to stroke RoundSuperellipse#169704
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
flar
left a comment
There was a problem hiding this comment.
Do we have existing tests that would notice this change here? I don't expect goldens to change because it is identical to making a path, but we avoid the overhead of the storage. But, we should make sure we have a golden/playground test that exercises it before we ask for a test exemption.
That looks stroked. Use that as justification and ask for a test exemption. |
|
CI had a failure that stopped further tests from running. We need to investigate to determine the root cause. SHA at time of execution: d8275c4. Possible causes:
A blank commit, or merging to head, will be required to resume running CI for this PR. Error Details: Stack trace: |
|
test-exempt: code refactor with no semantic change |

This PR creates a new class,
StrokeRoundSuperellipseGeometry, which reuses theStrokePathSourceGeometryclass to stroke rounded superellipses.Fixes #168419.
Filling is unchanged. I could have used
FillPathSourceGeometryfor non-uniform filling just like RRect, but I've decided not to after some experimentation, mostly because theRoundSuperellipseGeometryclass wouldn't be simplified from uniformity as much as we hope for. This might be worthwhile if one day we move the filling code toTessellator(just likeFilledRoundRect), which reuses much existing code. But that's out of the scope for now.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.