[ Tool ] Report Android x86 target devices as unsupported #170282
Conversation
|
@jmagman does this look like roughly the right thing to do? Adding |
| case 'x86_64': | ||
| return TargetPlatform.android_x64; | ||
| default: | ||
| return TargetPlatform.android_arm; | ||
| throw UnsupportedError('Unsupported Android architecture: $abi'); |
There was a problem hiding this comment.
This API seems weird - it never could throw before, and UnsupportedError shouldn't be caught.
I would expect this to either return null, or to return TargetPlatform.unsupported or keep returning android_arm and use that a signal for "not supported" below.
There was a problem hiding this comment.
Keeping and returning android_arm means we need to keep handling that case in every switch on TargetPlatform throughout the tool, so I'd really like to avoid doing that.
TargetPlatform.unsupported might be an idea... let me try some things out.
No description provided.