Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Re-split hot reload error and hot restart tests #170368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

Re-split hot reload error and hot restart tests #170368

merged 2 commits into from
Jun 13, 2025

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 10, 2025

After combining these 2 tests, they became very flaky, especially on Mac and Windows, but also on Linux.

Filed an issue: #170062

@mdebbar mdebbar requested a review from srujzs June 10, 2025 17:45
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 10, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit 5b0706c Jun 13, 2025
148 checks passed
@auto-submit auto-submit bot deleted the hot_reload_web_error_unsplit branch June 13, 2025 19:12
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
37f9fd7 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
3e36b0c 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
718399e 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
b3ec70c 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
5297c61 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
c28d5f7 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
00e1873 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
1aac348 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
976cf1c 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
a715803 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
3d4df19 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
331f2e8 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
1fb183f 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
9c200c4 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
246d3d2 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
9ac865c 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
d9c3866 
…utter#170368)
mdebbar added a commit that referenced this pull request Jun 24, 2025
@mdebbar
Revert "Re-split hot reload error and hot restart tests (#170368)"
b0d993a 
This reverts commit 5b0706c.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@mdebbar @mboetger
Re-split hot reload error and hot restart tests (flutter#170368)
5cc3ad8 
After [combining](flutter#169860) these
2 tests, they became very flaky, especially on Mac and Windows, but also
on Linux.

Filed an issue: flutter#170062
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
3d42f21 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
0501630 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
f972fcc 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
26d1984 
…utter#170368)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
5b0706c50 Re-split hot reload error and hot restart tests (flutter/fl…
719e107 
…utter#170368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdebbar @srujzs